-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC MP Implementation #8878
Merged
Merged
gRPC MP Implementation #8878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classes to helidon-grpc module. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
…still incomplete, but module now compiles. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Jun 12, 2024
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
spericas
force-pushed
the
issue-8794
branch
2 times, most recently
from
June 18, 2024 19:54
efbc4c9
to
20cbf3b
Compare
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
spericas
force-pushed
the
issue-8794
branch
2 times, most recently
from
June 21, 2024 18:03
00e2c50
to
6e6e1f0
Compare
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think the annotations should be in
helidon-microprofile-grpc-api
module - please make sure all public constructors are replaced with factory methods (unless they are allowed by our guidelines)
- please make sure we never accept
null
as a parameter value
There is a lot of reflection used here. It may be better to use annotation processing to generate all the needed stuff to be reflection free (maybe even use ServiceRegistry for this?).
webserver/grpc/src/main/java/io/helidon/webserver/grpc/ResponseHelper.java
Show resolved
Hide resolved
…backward compatibility. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
spericas
force-pushed
the
issue-8794
branch
3 times, most recently
from
July 5, 2024 19:25
52564dd
to
efb4400
Compare
…r testing gRPC. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
microprofile/grpc/api/src/main/java/io/helidon/microprofile/grpc/api/Bidirectional.java
Outdated
Show resolved
Hide resolved
microprofile/grpc/api/src/main/java/io/helidon/microprofile/grpc/api/ClientStreaming.java
Outdated
Show resolved
Hide resolved
microprofile/grpc/api/src/main/java/io/helidon/microprofile/grpc/api/Grpc.java
Outdated
Show resolved
Hide resolved
microprofile/grpc/api/src/main/java/io/helidon/microprofile/grpc/api/ServerStreaming.java
Outdated
Show resolved
Hide resolved
microprofile/grpc/api/src/main/java/io/helidon/microprofile/grpc/api/Unary.java
Outdated
Show resolved
Hide resolved
microprofile/grpc/api/src/main/java/io/helidon/microprofile/grpc/api/GrpcMethod.java
Outdated
Show resolved
Hide resolved
...rofile/grpc/core/src/main/java/io/helidon/microprofile/grpc/core/AbstractServiceBuilder.java
Show resolved
Hide resolved
microprofile/grpc/core/src/main/java/io/helidon/microprofile/grpc/core/AnnotatedMethod.java
Outdated
Show resolved
Hide resolved
webserver/grpc/src/main/java/io/helidon/webserver/grpc/GrpcTracingConfigBlueprint.java
Show resolved
Hide resolved
webserver/grpc/src/main/java/io/helidon/webserver/grpc/ResponseHelper.java
Show resolved
Hide resolved
…enever possible. A few other minor changes to follow our coding rules.
…hare annoations and types with future declarative SE API. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
…Service. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration of H3 gRPC MP Implementation into H4. gRPC in H3 MP started its own Netty-based server on a new port, the new implementation in H4 is fully intergrated with the web server, which is now capable of detecting the type of a connection and route its data to the correct handler. As a result of this new integration, there is new gRPC server configuration (there is no gRPC server anymore) and a few other integration points have changed.
Module Changes
gRPC MP Support
Just like in H3, there is now support for gRPC annotated endpoints:
In addition to annotated endpoints, the gRPC CDI extension will scan and automatically register any beans that implement
GrpcService
(from SE) andBindableService
(io.grpc), just like it did in H3.Server interceptors from the io.grpc API are support only on annotated types either by direct reference using the
@GrpcInterceptors
or via CDI name binding.Additional Features in PR
GrpcMpContext
SPI has also been ported to H4. It enables users to write CDI extensions that are given access to the CDIBeanManager
and the server'sGrpcRouting
builder.grpc.tracing.enabled
is set totrue
(defaults tofalse
)