Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-value query string parsing #8889

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix multi-value query string parsing #8889

merged 2 commits into from
Jun 17, 2024

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Jun 16, 2024 •
edited
Loading

Resolves #8886

When parsing a query with multiple values, we incorrectly called set instead of add, so only the last value was used.

Also the query must be encoded when used for parsing - fixed javadoc, and usage.

@tomas-langer tomas-langer added bug Something isn't working 4.x Version 4.x labels Jun 16, 2024
@tomas-langer tomas-langer self-assigned this Jun 16, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 16, 2024
@tomas-langer
Fixed handling of query methods.
08011a3 
Reverted to use raw query (as intended), and fixed javadoc of the method.
Added tests.
@tomas-langer tomas-langer requested a review from spericas June 16, 2024 15:13
spericas
spericas approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romain-grecourt romain-grecourt merged commit ed37d4f into helidon-io:main Jun 17, 2024
12 checks passed
@tomas-langer tomas-langer deleted the 8886-uri-query branch June 17, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

@romain-grecourt romain-grecourt romain-grecourt approved these changes

Assignees

@tomas-langer tomas-langer

Labels
4.x Version 4.x bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UriQueryWriteable.fromQueryString does not support multi-value parameters
3 participants
@tomas-langer @romain-grecourt @spericas