Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Fixed configuration metadata of blueprints that are configured and provide a service #8891

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Jun 16, 2024

Updated generated documentation to latest state of code.

Resolves #8776

There were two problems in the code:

  1. The protocol config blueprints used wrong provides (must match the @Option.Provider(ProtocolConfigProvider.class) in listener config)
  2. The protocol config blueprints lacked the configured key, and setting that it is not a root configuration

After fixing the above problems, the generated documentation correctly shows the configuration keys, and the listener config documentation now lists all available implementations.

In addition the same problem was with observe providers. Fixed all providers to add config key, re-generated the documentation.

Added validation that @Provides and @Configured must have a configuration key.

Updated generated documentation to latest state of code.
@tomas-langer tomas-langer self-assigned this Jun 16, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 16, 2024
Added validation of @provides with @configured - it must provide a configuration key now.
@tomas-langer tomas-langer changed the title 4.x: Fixed configuration metadata of protocol configs. 4.x: Fixed configuration metadata of blueprints that are configured and provide a service Jun 16, 2024
Validation errors now contain source type for better error messages.
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@barchetta barchetta merged commit d94706d into helidon-io:main Jun 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config-metadata.json lacks configKey for ConfiguredProviders
3 participants