Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves client protocol ID caching from HttpClientRequest to WebClient #8933

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Jul 1, 2024

Description

Moves client protocol ID caching from HttpClientRequest to WebClient level for proper sharing. See issue #8930.

Documentation

None

@spericas spericas added this to the 4.1.0 milestone Jul 1, 2024
@spericas spericas self-assigned this Jul 1, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 1, 2024
…level for proper sharing.

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas requested a review from tomas-langer July 1, 2024 20:39
tomas-langer
tomas-langer previously approved these changes Jul 2, 2024
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas merged commit bdac5a7 into helidon-io:main Jul 2, 2024
12 checks passed
barchetta pushed a commit to barchetta/helidon that referenced this pull request Jul 15, 2024
…elidon-io#8933)

* Moves client protocol ID caching from HttpClientRequest to WebClient level for proper sharing.
* Modifies test after caching changes in HttpClientRequest.
* Moves EndpointKey to LoomClient.

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>

---------

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
barchetta added a commit that referenced this pull request Jul 16, 2024
…bClient (#8987)

* Moves client protocol ID caching from HttpClientRequest to WebClient (#8933)

* Moves client protocol ID caching from HttpClientRequest to WebClient level for proper sharing.
* Modifies test after caching changes in HttpClientRequest.
* Moves EndpointKey to LoomClient.

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>

---------

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>

* Fix copyright

---------

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. performance website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants