Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing log message on breach of overallTimeout duration #8936

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

anandbibek
Copy link
Contributor

Description

The log message printed out on breach of overallTimeout property in Helidon fault-tolerance Retry module is confusing and misleading.

Existing

io.helidon.faulttolerance.RetryTimeoutException: Execution took too long. Already executing: 80344961 ms, must timeout after: 1000 ms.

Updated

io.helidon.faulttolerance.RetryTimeoutException: Execution took too long. Already executing for: 1460 ms, must be lower than overallTimeout duration of: 1000 ms.

Documentation

No doc impact

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 2, 2024
@tjquinno tjquinno requested review from tomas-langer and spericas July 2, 2024 11:46
@anandbibek
Copy link
Contributor Author

Hi @spericas, could you please take a look at this?

@spericas spericas merged commit d0b2d63 into helidon-io:main Jul 16, 2024
12 checks passed
@anandbibek anandbibek deleted the fix-retry-logging branch July 28, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x fault-tolerance OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants