Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to read an unconsumed response entity to allow connection caching #8943

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Jul 8, 2024

Description

Attempt to read an unconsumed response entity to allow connections to be re-used. Optimization only works for length-prefixed entities and when the entity has not been partially read --the goal is not to block the thread attempting to close the response while trying to improve connection caching. Issue #8931.

@spericas spericas added performance 4.x Version 4.x labels Jul 8, 2024
@spericas spericas self-assigned this Jul 8, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 8, 2024
@spericas spericas marked this pull request as draft July 8, 2024 14:32
… be re-used. Optimization only works for length-prefixed entities.

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas marked this pull request as ready for review July 16, 2024 17:01
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas requested a review from tomas-langer July 16, 2024 18:55
@spericas spericas merged commit 00e114b into helidon-io:main Jul 16, 2024
12 checks passed
barchetta pushed a commit to barchetta/helidon that referenced this pull request Jul 16, 2024
…hing (helidon-io#8943)

* Attempt to read an unconsumed response entity to allow connections to be re-used. Optimization only works for length-prefixed entities.

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>

* Replaces loop by call to skip.

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>

---------

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
barchetta added a commit that referenced this pull request Jul 16, 2024
…hing (#8943) (#8996)

* Attempt to read an unconsumed response entity to allow connections to be re-used. Optimization only works for length-prefixed entities.
* Replaces loop by call to skip.

---------

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement. performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants