Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8728
Major changes by component:
Helidon now adds additional tags to spans (
HTTP_ROUTE
,NET_PEER_NAME
,NET_PEER_PORT
) as required by MP Telemetry 1.1.Helidon now sets the span status in accordance with the OpenTelemetry semantic conventions. See https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status.
The more recent OTel semantic conventions require the HTTP method to be in the span name for REST spans. https://opentelemetry.io/docs/specs/semconv/http/http-spans/#name This is a backward-incompatible change from MP Telemetry 1.0 and, therefore, earlier releases of Helidon 4.0.x.
For backward compatibility with earlier releases of 4.0.x, Helidon does not by default include the HTTP method in REST span names. In this case Helidon displays a warning during start-up that the behavior is deprecated.
Users can choose the newer, spec-compliant but backward-incompatible behavior by setting the Helidon-specific
mp.telemetry.span.name-includes-method
config property totrue
.The PR includes a new unit test which exercises the config setting.
Using
was apparently always intended to provide access to the span that is current at the time of use, not the current span at the time of injection. This is now checked in the TCK and Helidon now conforms.
WritableBaggage
API now supports aset(key, value, metadataString)
method which defaults tothis.set(key, value, "")
The OTel tracing provider now deals with baggage metadata; the other providers ignore metadata.Documentation
This PR adds a note to the MP telemetry page about the REST span naming incompatibility and the config option to use the newer format.