Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.11: Convert ConcurrentHashMap which does service loading to HashMap with reentrant lock #8991

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

barchetta
Copy link
Member

Description

Backport #8977 to 4.0.11

Resolves #8967

The computeIfAbsent code applied to the SUPPLIERS ConcurrentHashMap performs service loading. Use a HashMap with an explicit guarding lock instead.

Documentation

No impact

…ith `ReentrantLock` (helidon-io#8977)

* Convert ConcurrentHashMap which does service loading to HashMap with ReentrantLock

Signed-off-by: Tim Quinn <tim.quinn@oracle.com>

* Use a RW lock

* Replace the contentious ConcurrentHashMap with a HashMap (with the lock) (which was the whole point after all)

---------

Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
@barchetta barchetta added backport Issues that are merged into a single branch, but missing in either master or previous release 4.x Version 4.x observability labels Jul 15, 2024
@barchetta barchetta added this to the 4.0.11 milestone Jul 15, 2024
@barchetta barchetta requested a review from tjquinno July 15, 2024 23:31
@barchetta barchetta self-assigned this Jul 15, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 15, 2024
@barchetta barchetta merged commit 2c66e39 into helidon-io:helidon-4.0.11 Jul 16, 2024
12 checks passed
@barchetta barchetta deleted the 4.0.11-8977-obs-pin branch November 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x backport Issues that are merged into a single branch, but missing in either master or previous release observability OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants