Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.11: Skip test if InstancePrincipal UT if Imds is available #8992

Merged

Conversation

barchetta
Copy link
Member

Description

Backport of #8985 to 4.0.11

TestInstancePrincipalsAuthenticationDetailsProvider is a negative test that validates a failure will take place if authentication is done on an environment with no Imds avaialable like an OCI instance, hence this will fail if the test is executed on an environment where Imds is available.

Documentation

No impact

* Skip test if InstancePrincipal UT if Imds is available

TestInstancePrincipalsAuthenticationDetailsProvider is a negative test that validates a failure will take place if authentication is done on an environment with no Imds avaialable like an OCI instance, hence this will fail if the test is executed on an environment where Imds is available.

* Refactor imdsAvailable into a utility class so it can be reused
@barchetta barchetta added testing OCI backport Issues that are merged into a single branch, but missing in either master or previous release 4.x Version 4.x labels Jul 16, 2024
@barchetta barchetta added this to the 4.0.11 milestone Jul 16, 2024
@barchetta barchetta requested a review from klustria July 16, 2024 00:15
@barchetta barchetta self-assigned this Jul 16, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 16, 2024
Copy link
Member

@klustria klustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@barchetta barchetta merged commit d529943 into helidon-io:helidon-4.0.11 Jul 16, 2024
12 checks passed
@barchetta barchetta deleted the 4.0.11-8985-ocisdk-test branch November 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x backport Issues that are merged into a single branch, but missing in either master or previous release OCA Verified All contributors have signed the Oracle Contributor Agreement. OCI testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants