Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UriEncoding.decode to expose a decodeQuery method #9006

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

romain-grecourt
Copy link
Contributor

Description

  • UriEncoding.decodeQuery does not ignore %s within []
  • UriEncoding.decodeUri ignores %s within [] to support IPv6 literal (E.g. http://[fe80::1%lo0]:8080)

See https://tools.ietf.org/html/rfc6874#section-2

Fixes #8993

Documentation

None

- UriEncoding.decodeQuery does not ignore %s within []
- UriEncoding.decodeUri ignores %s within [] to support IPv6 literal (E.g. http://[fe80::1%lo0]:8080)

See https://tools.ietf.org/html/rfc6874#section-2

Fixes helidon-io#8993
@romain-grecourt romain-grecourt self-assigned this Jul 18, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 18, 2024
@romain-grecourt romain-grecourt merged commit 6764d30 into helidon-io:main Jul 18, 2024
12 checks passed
@romain-grecourt romain-grecourt deleted the gh-8993 branch July 18, 2024 18:57
barchetta pushed a commit to barchetta/helidon that referenced this pull request Jul 18, 2024
…9006)

- UriEncoding.decodeQuery does not ignore %s within []
- UriEncoding.decodeUri ignores %s within [] to support IPv6 literal (E.g. http://[fe80::1%lo0]:8080)

See https://tools.ietf.org/html/rfc6874#section-2

Fixes helidon-io#8993
barchetta added a commit that referenced this pull request Jul 18, 2024
- UriEncoding.decodeQuery does not ignore %s within []
- UriEncoding.decodeUri ignores %s within [] to support IPv6 literal (E.g. http://[fe80::1%lo0]:8080)

See https://tools.ietf.org/html/rfc6874#section-2

Fixes #8993

Co-authored-by: Romain Grecourt <romain.grecourt@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query params with URI encoded enclosed in brackets is not decoded
2 participants