Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Fix SetCookie to work for client side as well #9029

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

tomas-langer
Copy link
Member

Resolves #9004

  • Add getters for all fields of SetCookie
  • Fix parse method to support SameSite
  • Added test to validate new features

The SetCookie class was only designed for server side. Once the parse method was added, we provided a way for client side to read it. This resulted in the referenced bug.

Fix parse method to support SameSite
Added test to validate new features
@tomas-langer tomas-langer added bug Something isn't working common 4.x Version 4.x labels Jul 23, 2024
@tomas-langer tomas-langer self-assigned this Jul 23, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 23, 2024
@tomas-langer tomas-langer requested a review from spericas July 23, 2024 16:17
@tomas-langer tomas-langer merged commit c9e91c6 into helidon-io:main Jul 23, 2024
12 checks passed
@tomas-langer tomas-langer deleted the 9004-set-cookie branch July 23, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working common OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.0.10] Parsing http cookies with SameSite attribute - possible bug ?
2 participants