4.x: Reenables failing JPA test #9037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
previously approved these changes
Jul 24, 2024
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
tjquinno
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables the
TestAnnotationRewriting#testNonTransactionalEntityManager()test. Closes #8122.This PR ensures that this test suite is set up to properly test the old JPA integration classes (primarily
JpaExtension), which coexist, normally dormantly, with the new-and-supported JPA integration classes (primarilyPersistenceExtension). It does so by ensuring that the deliberately undocumented system properties controlling enablement and disablement are set appropriately for this test suite. They had not been so set in the past, and that's one of the reasons the test was failing.Given that there have not been any complaints for a couple of releases now about the new overhauled JPA stuff, it means it has proven itself in the wild to be backwards compatible. Consequently, I will open a subsequent issue to remove this coexistence/old stuff and the
JpaExtensionclass, and any test suites that exercise it.