Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark deprecations for Micrometer integration component #9085

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Aug 1, 2024

Description

Resolves #8946

Releases before 4.x provided some convenient ways developers could use Micrometer in their applications, including some configuration help and CDI injection and interceptor support for the Micrometer annotations and meter types. Using those tools, the Micrometer meters were completely separate from the Helidon metrics managed using the Helidon metrics API.

Now that Helidon 4 uses Micrometer for its own metrics implementation, the former approach is obsolete, inefficient, and unneeded.

As one step of providing even better integration with Micrometer, this PR marks as deprecated-for-removal the public types of the integration component; we plan to remove them in a future major release of Helidon.

Documentation

There are existing files in our docs area for Micrometer integration, but there are no links to them on our 4.x doc pages. So there are no doc updates needed as part of this PR.

@tjquinno tjquinno requested review from spericas and barchetta August 1, 2024 19:40
@tjquinno tjquinno self-assigned this Aug 1, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 1, 2024
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit d3b6f7b into helidon-io:main Aug 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x Deprecate Micrometer integration component and add "how to use Micrometer API" content to metrics doc
2 participants