Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Replace deprecated method Scheduling.fixedRateBuilder() on Scheduling.fixedRate() #9098

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Captain1653
Copy link
Contributor

Description

I've found, that the deprecated method Scheduling.fixedRateBuilder() is used in the code. The method was marked as deprecated in this commit.

Screenshot 2024-08-03 at 17 55 44

It can be replaced on Scheduling.fixedRate()

There are some tests for Scheduling.fixedRateBuilder(), but I didn't touch them. Should I do it?

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 3, 2024
@barchetta barchetta requested a review from danielkec August 5, 2024 15:05
@barchetta barchetta assigned barchetta and danielkec and unassigned barchetta Aug 5, 2024
@barchetta barchetta added the 4.x Version 4.x label Aug 5, 2024
@Captain1653
Copy link
Contributor Author

@barchetta Can it be merged? Please :) One check gate can't start, unfortunately.

@romain-grecourt
Copy link
Contributor

@barchetta Can it be merged? Please :) One check gate can't start, unfortunately.

Your branch was not based on the latest main, I did rebase it for you.

@Captain1653
Copy link
Contributor Author

@romain-grecourt Thank you

@barchetta barchetta merged commit 247334f into helidon-io:main Aug 29, 2024
44 checks passed
tjquinno pushed a commit to tjquinno/helidon that referenced this pull request Aug 29, 2024
@Captain1653 Captain1653 deleted the fixed-rate-deprecated branch August 30, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants