4.x: UncheckedIOException no longer a special case #9206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Server I/O failures now throw a ServerConnectionException, and that extends the CloseConnectionException (which already has its special handling). This change allows user to handle UncheckIOException as if it is any other throwable. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
webserver/http2/src/main/java/io/helidon/webserver/http2/Http2Connection.java
Outdated
Show resolved
Hide resolved
...erver/tests/webserver/src/test/java/io/helidon/webserver/tests/UncheckedIoExceptionTest.java
Outdated
Show resolved
Hide resolved
...erver/tests/webserver/src/test/java/io/helidon/webserver/tests/UncheckedIoExceptionTest.java
Outdated
Show resolved
Hide resolved
...erver/tests/webserver/src/test/java/io/helidon/webserver/tests/UncheckedIoExceptionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
requested changes
Aug 27, 2024
webserver/webserver/src/main/java/io/helidon/webserver/http1/Http1Connection.java
Outdated
Show resolved
Hide resolved
…ttp1Connection.java Co-authored-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
approved these changes
Aug 27, 2024
romain-grecourt
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9192
No longer using UncheckedIOException as a special case for the server.
Server I/O failures now throw a ServerConnectionException, and that extends the CloseConnectionException (which already has its special handling).
This change allows user to handle UncheckIOException as if it is any other throwable.
As part of this change:
UncheckedIOExceptionThis is a small behavior change. The original behavior was not documented, and the result was not ideal (as we would close connection even if the
UncheckedIOExceptioncame from client call to another service).The new behavior only closes connection with specific exception.