New implementation for SSE in webserver #9224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
changed the title
…tation does not use the normal output stream to serialize the events to avoid problems with buffering and chunked encoding. Instead, it writes directly to the underlying socket writer and flushes data as needed. As a result, chunked encoding is no longer used for SSE. Several tests have been updated.
spericas
force-pushed
the
issue-9164
branch
3 times, most recently
from
f22c2d3 to
7fc6e09
Compare
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
webclient/http1/src/main/java/io/helidon/webclient/http1/Http1CallChainBase.java
Outdated
Show resolved
Hide resolved
webclient/http1/src/main/java/io/helidon/webclient/http1/Http1CallChainBase.java
Outdated
Show resolved
Hide resolved
webserver/sse/src/main/java/io/helidon/webserver/sse/SseSink.java
Outdated
Show resolved
Hide resolved
webserver/sse/src/main/java/io/helidon/webserver/sse/SseSinkProvider.java
Show resolved
Hide resolved
spericas
force-pushed
the
issue-9164
branch
from
b9cd3d2 to
fea7299
Compare
…er SSE implementation, which is also kept around. Changes to SseSink to support multiple implementations.
spericas
force-pushed
the
issue-9164
branch
from
fea7299 to
5101635
Compare
tomas-langer
approved these changes
Sep 26, 2024
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Sep 27, 2024
Provides a new implementation for SSE in the webserver. This implementation does not use the normal output stream to serialize the events to avoid problems with buffering and chunked encoding. Instead, it writes directly to the underlying socket writer and flushes data as needed. As a result, chunked encoding is no longer used for SSE. Several tests have been updated.
barchetta
added a commit
that referenced
this pull request
Sep 27, 2024
Provides a new implementation for SSE in the webserver. This implementation does not use the normal output stream to serialize the events to avoid problems with buffering and chunked encoding. Instead, it writes directly to the underlying socket writer and flushes data as needed. As a result, chunked encoding is no longer used for SSE. Several tests have been updated. Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides a new implementation for SSE in webserver. This implementation does not use the normal output stream to serialize the events to avoid problems with buffering and chunked encoding. Instead, it writes directly to the underlying socket writer and flushes data as needed. As a result, chunked encoding is no longer used for SSE. Several tests have been updated. Fixes #9164.
Summary of Changes
createmethod inSinkProviderthat deprecates the old one. This change is required for the new implementation. Not a very popular SPI, but we shall continue to support the old method (and continue to include the old implemtnation) for some time. ClassHttp1ServerResponseupdated accordingly.SseSinkthat writes directly to a writer. Also needs to write response status line and headers. No longer uses the output stream from the response.SimpleSseClientclass to test SSE endpoints without usingWebClient. This is required because we don't use chunked encoding anymore. Related tests have been updated.