Attempt to fix infinite await in Jersey output writer. #9460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The count down latch is now counted down in close method of the output stream, which should cover all the possible cases (unless close is not called, which would cause other major issues as well, so the case is not handled). Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
jbescos
approved these changes
Nov 4, 2024
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Nov 4, 2024
The count down latch is now counted down in close method of the output stream, which should cover all the possible cases (unless close is not called, which would cause other major issues as well, so the case is not handled). Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
barchetta
added a commit
that referenced
this pull request
Nov 4, 2024
The count down latch is now counted down in close method of the output stream, which should cover all the possible cases (unless close is not called, which would cause other major issues as well, so the case is not handled). Signed-off-by: Tomas Langer <tomas.langer@oracle.com> Co-authored-by: Tomas Langer <tomas.langer@oracle.com>
arjav-desai
pushed a commit
to arjav-desai/helidon
that referenced
this pull request
Dec 11, 2024
The count down latch is now counted down in close method of the output stream, which should cover all the possible cases (unless close is not called, which would cause other major issues as well, so the case is not handled). Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count down latch is now counted down in close method of the output stream, which should cover all the possible cases (unless close is not called, which would cause other major issues as well, so the case is not handled).
Resolves #9442