Adds support for async on @ExecuteOn methods #9551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
danielkec
approved these changes
Dec 5, 2024
Comment on lines
+149
to
+155
| // if resultFuture is cancelled, then cancel supplyFuture | ||
| resultFuture.exceptionally(t -> { | ||
| if (t instanceof CancellationException) { | ||
| supplyFuture.cancel(mayInterrupt.get()); | ||
| } | ||
| return null; | ||
| }); |
There was a problem hiding this comment.
Such a shame thenCompose doesn't propagate cancel
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Dec 5, 2024
* Adds support for async on @ExecuteOn methods. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com> * New test that verifies correct unwrapping of exceptions. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com> --------- Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
barchetta
added a commit
that referenced
this pull request
Dec 5, 2024
* Adds support for async on @ExecuteOn methods. * New test that verifies correct unwrapping of exceptions. --------- Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com> Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
arjav-desai
pushed a commit
to arjav-desai/helidon
that referenced
this pull request
Dec 11, 2024
* Adds support for async on @ExecuteOn methods. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com> * New test that verifies correct unwrapping of exceptions. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com> --------- Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for async on @ExecuteOn methods. Issue #9539.
Documentation
Has been updated.