Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP draft: guidelines for software releases #290

Merged
merged 3 commits into from
Nov 13, 2021
Merged

Conversation

ganey
Copy link
Contributor

@ganey ganey commented Oct 13, 2021

Add HIP to update software release guidelines
@ganey ganey changed the title Create 0043-update-release-guidelines.md HIP43: update software release guidelines Oct 15, 2021
@jamiew jamiew added the draft label Oct 27, 2021
@jamiew jamiew changed the title HIP43: update software release guidelines HIP draft – guidelines for software releases Oct 27, 2021
@jamiew jamiew changed the title HIP draft – guidelines for software releases HIP draft: guidelines for software releases Oct 27, 2021
@shawaj
Copy link
Contributor

shawaj commented Oct 27, 2021

I like this, it certainly makes a lot of sense.

One idea - Why not just have a timeline for GAs to be released? Like 1 week from when helium tag it or something. Then you don't need to account for the complexities of all of the worldwide public holidays

@ganey
Copy link
Contributor Author

ganey commented Oct 28, 2021

Like 1 week from when helium tag it or something. Then you don't need to account for the complexities of all of the worldwide public holidays

That would be good, I spoke to a few people in Discord about it and it seems that is how it's supposed to be already. I guess the issue at the moment is releases keep containing network/mining tweaks that make everything a bit messy until all the miners have updated.

I think poc 11 was handled better by being released a while before activation date, giving vendors time to update without having to work out of hours/weekends.

Some don't quite see this as a HIP as it doesn't actually change anything in the code, and see it more as a thing for the devs. I feel if it makes an improvement to Helium then this is probably where it belongs.

Update explanation to include possibility of a timeframe to implement updates (suggested by @shawaj)
@shawaj
Copy link
Contributor

shawaj commented Oct 28, 2021

Yeah I feel like even procedural guidelines changes / introductions should be HIPs too.

Perhaps the "mandatory" updates that are often the breaking ones and are less frequent - could be behind chain vars. I guess the only downside to this is that it's more effort for the core team. But certainly having a rollout time between GA and "go live" would be useful IMO... From a device user perspective too

@jamiew jamiew merged commit 43a9e0e into helium:master Nov 13, 2021
@jamiew
Copy link
Contributor

jamiew commented Nov 13, 2021

This HIP draft has been numbered and merged for discussion as HIP 43. Please direct future questions & comments to the new tracking issue: #309

If you are one of the named authors, please include #309 in future pull requests to have them automatically merged.

I updated the title for clarity – I hope that is OK. If you prefer the older one please get in touch

jamiew added a commit that referenced this pull request Nov 13, 2021
* Create 0043-update-release-guidelines.md

Add HIP to update software release guidelines

* Update 0043-update-release-guidelines.md

Update explanation to include possibility of a timeframe to implement updates (suggested by @shawaj)

* Change "update" to "software" for clarity

Co-authored-by: Jamie Dubs <jamie@jamiedubs.com>
jamiew added a commit that referenced this pull request Nov 13, 2021
* HIP-4x LoRaWAN Frequency Plan Selection

* implement feedback from ivandigiusto

* do PRs against docs

* expand on impact

* Mark HIP-28 as deployed (#296)

* Number and merge HIP 41: Governance by Token Lock V2 (#299)

Co-authored-by: Jamie Wilkinson <jamie@jamiedubs.com>

* New HIP 42 Beacon/Witness Ratio - Witness Reward Limit (#289)

* HIP-42 initial submission
* Better aligned name to proposal
* v2
* Number and merge HIP 42

Co-authored-by: Jamie Wilkinson <jamie@jamiedubs.com>

* Update HIP 41 with latest edits (#304)

* HIP draft: guidelines for software releases (#290)

* Create 0043-update-release-guidelines.md

Add HIP to update software release guidelines

* Update 0043-update-release-guidelines.md

Update explanation to include possibility of a timeframe to implement updates (suggested by @shawaj)

* Change "update" to "software" for clarity

Co-authored-by: Jamie Dubs <jamie@jamiedubs.com>

* HIP draft: Witness Reward Decay (#292)

* initial draft

* Update xxxx-witness-decay.md

* Number as 44

Co-authored-by: Jamie Dubs <jamie@jamiedubs.com>

* Number as HIP 44

Co-authored-by: PaulVMo <paul.moceri@gmail.com>
Co-authored-by: Scott Sigel <scott@commonwealthcrypto.com>
Co-authored-by: Jamie Wilkinson <jamie@jamiedubs.com>
Co-authored-by: Anthony Anderson <fnanderson93@gmail.com>
Co-authored-by: Abhay Kumar <abhay@helium.com>
Co-authored-by: Ganey <ganey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants