Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose Transfer Hotspot #42

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Propose Transfer Hotspot #42

merged 4 commits into from
Sep 29, 2020

Conversation

abhay
Copy link
Contributor

@abhay abhay commented Sep 23, 2020

Summary: This proposal introduces a new type of transaction to the Helium blockchain called transfer_gateway_v1. This transaction will be an atomic transfer of an onboarded Hotspot / gateway from one owner to another. This transaction can have an optional amount of HNT associated.

Rendered version: https://github.com/helium/HIP/blob/9cf52310b532d98232d21de33449ce789c58ef10/0099-transfer-hotspot.md

@abhay abhay marked this pull request as draft September 23, 2020 09:00
@jamiew jamiew added the draft label Sep 24, 2020
@abhay abhay assigned jadeallenx and unassigned macpie Sep 28, 2020

## Implement the transaction in the helium-wallet client

`TODO`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madninja and I talked about this today and we're not sure we should go into great detail here - the helium-wallet already supports "exporting" a partially completed transaction as either a QR code format or a Base64 encoded text blob - either of these formats would be useful for completing the transaction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably enough information exactly as described. Want to add it or me?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thanks

0099-transfer-hotspot.md Outdated Show resolved Hide resolved
0099-transfer-hotspot.md Outdated Show resolved Hide resolved
@abhay abhay removed the draft label Sep 29, 2020
@abhay abhay marked this pull request as ready for review September 29, 2020 06:57
@abhay
Copy link
Contributor Author

abhay commented Sep 29, 2020

@jamiew I feel like this is good to land. Should I adjust the HIP # and filename?

@jamiew jamiew mentioned this pull request Sep 29, 2020
@jamiew jamiew merged commit a42d81b into master Sep 29, 2020
@jamiew jamiew deleted the abhay/transfer-hotspot branch September 29, 2020 18:42
@jamiew
Copy link
Contributor

jamiew commented Sep 29, 2020

Numbered, squashed & merged. Thanks for your business!

Please direct future discussion to the tracking issue: #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants