Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP 118: Verification Mapping for MOBILE Network #950

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

zer0tweets
Copy link
Contributor

Adding HIP for verification mapping

Adding HIP for verification mapping
@waveform06 waveform06 added technical Technical HIPs economic Economic HIP MOBILE labels Mar 21, 2024
@heatedlime
Copy link
Contributor

heatedlime commented Mar 21, 2024

@zer0tweets need to add .md after the name so it can render as markup formatting.

Copy link
Contributor

@abhay abhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

started a bunch of edits here but really prefer if we could have HIP authors do a better job cleaning up a HIP before publicly stating this is "ready for a channel and discussion"

0XXX-verification-mapping Outdated Show resolved Hide resolved
0XXX-verification-mapping Outdated Show resolved Hide resolved
Comment on lines 12 to 16
[HIP 79 ](https://github.com/helium/HIP/blob/main/0079-mobile-poc-mappers-rewards.md) established general framework of discovery and verification mapping and related MOBILE reward pools

[HIP 84](https://github.com/helium/HIP/blob/main/0084-service-provider-hex-boosting.md) established the framework for service providers to boost hexes by burning MOBILE

[HIP 103](https://github.com/helium/HIP/blob/main/0103-oracle-hex-boosting.md) introduced the established the framework for automated boosting of certain hexes based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"based on... "?

0XXX-verification-mapping Outdated Show resolved Hide resolved
0XXX-verification-mapping Outdated Show resolved Hide resolved
@abhay
Copy link
Contributor

abhay commented Mar 25, 2024

Any plans to update here?

zer0tweets and others added 4 commits March 28, 2024 13:09
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
…ing.md

- clean up various formatting errors 
- add MD to file name

* [HIP 79](https://github.com/helium/HIP/blob/main/0079-mobile-poc-mappers-rewards.md) established general framework of discovery and verification mapping and related MOBILE reward pools
* [HIP 84](https://github.com/helium/HIP/blob/main/0084-service-provider-hex-boosting.md) established the framework for service providers to boost hexes by burning MOBILE
* [HIP 103](https://github.com/helium/HIP/blob/main/0103-oracle-hex-boosting.md) introduced the established the framework for automated boosting of certain hexes based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still missing the end of the sentence.

0XXX-verification-mapping.md Outdated Show resolved Hide resolved
0XXX-verification-mapping.md Outdated Show resolved Hide resolved
zer0tweets and others added 3 commits March 28, 2024 15:08
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
- Fixed incomplete sentence 
- A few other minor type updates
@hiptron hiptron changed the title Create 0XXX-verification-mapping HIP 118: Verification Mapping for MOBILE Network Mar 28, 2024
@hiptron hiptron merged commit d0f047b into helium:main Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
economic Economic HIP MOBILE technical Technical HIPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants