This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
HIP 16 implementation #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhay
reviewed
Nov 6, 2020
src/blockchain_election.erl
Outdated
| {Remove, Replace} = determine_sizes(Size, OldLen, Delay, Ledger), | ||
|
|
||
| %% remove dupes, sort | ||
| {OldGroupScored0, Gateways1} = dedup(OldGroup0, Gateways0, Ledger), |
There was a problem hiding this comment.
nit: I know this is probably just to keep the code super similar but calling it "Scored" is confusing.
There was a problem hiding this comment.
Not as confusing any more now that I saw the default score of 1.0 thing.
vihu
reviewed
Nov 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 67.96% 68.11% +0.14%
==========================================
Files 93 93
Lines 12175 12211 +36
==========================================
+ Hits 8275 8317 +42
+ Misses 3900 3894 -6
Continue to review full report at Codecov.
|
|
LG! |
Vagabond
approved these changes
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new election behavior that ignores hotspot scores in both selection and old elector removal. It will need to be activated by chain var, seeing
election_versionto4.