This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
dialyzer surgery #273
Open
dialyzer surgery #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madninja
reviewed
Apr 28, 2020
| @@ -65,11 +65,6 @@ | |||
|
|
|||
| {shell, [{apps, [lager, ranch]}]}. | |||
|
|
|||
| {dialyzer, [ | |||
| {warnings, [unknown]}, | |||
There was a problem hiding this comment.
I wasn't expecting you'd have to strip this section out after you fixed the abuse of handle_gossip_data?
There was a problem hiding this comment.
I had to get rid of this to get rid of the throttle errors I was seeing. maybe I didn't need to?
Vagabond
reviewed
Apr 28, 2020
| @@ -88,8 +88,7 @@ put(#peerbook{tid=TID, stale_time=StaleTime}=Handle, PeerList0, Prevalidated) -> | |||
| false -> lists:filter(fun libp2p_peer:verify/1, PeerList0) | |||
| end, | |||
| ThisPeerId = libp2p_swarm:pubkey_bin(TID), | |||
| %% XXX uncomment this to reject any peers publishing RFC1918 addresses once the network has transitioned over | |||
| AllowRFC1918 = true, %% is_rfc1918_allowed(TID), | |||
| AllowRFC1918 = is_rfc1918_allowed(TID), | |||
There was a problem hiding this comment.
We should check we don't have many peers advertising RFC1918 addresses before we merge this.
There was a problem hiding this comment.
I'll check that tomorrow morning.
Vagabond
reviewed
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have to abuse the type system a little here to get it to ignore the horrors we're committing for the pre-decode speedup.