This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
gossip server scaling hackery #305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihu
reviewed
Dec 22, 2020
| @@ -63,7 +64,7 @@ handle_data(Pid, StreamPid, Key, {Path, Bin}) -> | |||
| gen_server:cast(Pid, {handle_data, StreamPid, Key, ListOrData}). | |||
|
|
|||
| accept_stream(Pid, SessionPid, StreamPid, Path) -> | |||
| gen_server:call(Pid, {accept_stream, SessionPid, StreamPid, Path}). | |||
| gen_server:call(Pid, {accept_stream, SessionPid, StreamPid, Path}, 30000). | |||
There was a problem hiding this comment.
Maybe make the timeout configurable?
Vagabond
reviewed
Jan 5, 2021
| lager:warning("Stopping on accept_stream exit: ~s", | ||
| [error_logger_lager_h:format_reason(Exit)]), | ||
| {stop, normal} | ||
| libp2p_session:identify(Session, self(), {ignore, self(), Path}), |
There was a problem hiding this comment.
I would make this the body of the accept_stream function and make handle_identify private to the gossip server
evanmcc
force-pushed
the
pevm/more-async
branch
from
bc4af3d
to
0b5379a
Compare
Vagabond
force-pushed
the
pevm/more-async
branch
from
598a2d7
to
7f135ea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some attempts to make the scaling situation better for the seed nodes.