Skip to content

Commit

Permalink
Merge pull request #412 from helium/jsk/disable-attestation-manifests
Browse files Browse the repository at this point in the history
Do not package attestation manifests with docker images
  • Loading branch information
madninja authored Apr 6, 2023
2 parents e362b75 + 14f635a commit 3ad4f7e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ jobs:

# We publish all builds to the test-images repo.
- name: Build | Test Image
env:
# The attestation manifests cause build errors for some makers.
# See https://github.com/helium/gateway-rs/issues/409
BUILDX_NO_DEFAULT_ATTESTATIONS: 1
run: |
docker buildx build \
--platform linux/arm64,linux/amd64 \
Expand All @@ -174,6 +178,10 @@ jobs:
# Publish to miner quay-repo on release only.
- name: Build | Release Image
env:
# The attestation manifests cause build errors for some makers.
# See https://github.com/helium/gateway-rs/issues/409
BUILDX_NO_DEFAULT_ATTESTATIONS: 1
if: startsWith(github.ref, 'refs/tags')
run: |
docker buildx build \
Expand Down
4 changes: 0 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
#
# docker buildx build --platform linux/arm64,linux/amd64 .
#
# Adding support for additional architectures requires editing the
# `case "$TARGETPLATFORM" in` in the build stage (and likely quite a
# bit of googling).
#
# 1: https://www.docker.com/blog/how-to-rapidly-build-multi-architecture-images-with-buildx
# 2: https://docs.docker.com/build/install-buildx
# ==============================================================================
Expand Down

0 comments on commit 3ad4f7e

Please sign in to comment.