feat: add builds and use prebuilt action #415

shawaj · 2023-04-11T18:47:44Z

add ecc608 based x86_64 image (LongAP uses this configuration)
add docker builds for armv6 and armv7 via qemu
change the build and push step to use the prebuilt docker action
add github actions cache to builder action step to speed up future builds
fix typos and add a bit more detail to readme

~~- gateway-mfr-rs uses aarch64-unknown-linux-gnu instead of aarch64-unknown-linux-musl so this unifies the two~~
~~- adds missing armv7-unknown-linux-gnueabihf which is built in gateway-mfr-rs~~

shawaj · 2023-04-11T20:16:46Z

As per helium/proto#318

I was attempting to build for aarch64-unknown-linux-gnu and armv7-unknown-linux-gnueabihf which are mentioned as being supported in gateway-rs readme (and used to be built for) but seem to have got lost in the migration from deb packages to tarballs.

however both fail with this error:

error: failed to run custom build command for `helium-proto v0.1.0 (https://github.com/helium/proto?branch=master#6edba809)`

Caused by:
  process didn't exit successfully: `/target/release/build/helium-proto-62cbd62839dbfd84/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-changed=src/blockchain_txn.proto
  cargo:rerun-if-changed=src/entropy.proto
  cargo:rerun-if-changed=src/data_rate.proto
  cargo:rerun-if-changed=src/region.proto
  cargo:rerun-if-changed=src/mapper.proto
  cargo:rerun-if-changed=src/reward_manifest.proto
  cargo:rerun-if-changed=src/blockchain_region_param_v1.proto
  cargo:rerun-if-changed=src/price_report.proto
  cargo:rerun-if-changed=src/service/router.proto
  cargo:rerun-if-changed=src/service/state_channel.proto
  cargo:rerun-if-changed=src/service/local.proto
  cargo:rerun-if-changed=src/service/gateway.proto
  cargo:rerun-if-changed=src/service/transaction.proto
  cargo:rerun-if-changed=src/service/follower.proto
  cargo:rerun-if-changed=src/service/poc_mobile.proto
  cargo:rerun-if-changed=src/service/poc_lora.proto
  cargo:rerun-if-changed=src/service/poc_entropy.proto
  cargo:rerun-if-changed=src/service/packet_router.proto
  cargo:rerun-if-changed=src/service/iot_config.proto
  cargo:rerun-if-changed=src/service/mobile_config.proto
  cargo:rerun-if-changed=src/service/downlink.proto
  cargo:rerun-if-changed=src/service/multi_buy.proto
  cargo:rerun-if-changed=src/service/packet_verifier.proto
  cargo:rerun-if-changed=src

  --- stderr
  Error: Custom { kind: Other, error: "protoc failed: blockchain_txn.proto:1:10: Unrecognized syntax identifier \"proto3\".  This parser only recognizes \"proto2\".\n" }
warning: build failed, waiting for other jobs to finish...
[cargo-make] ERROR - Error while executing command, exit code: 101
[cargo-make] WARN - Build Failed.
Error: Process completed with exit code 1.

madninja · 2023-04-11T20:22:47Z

They "got lost" because no-one was actually using them. Do you have a use for them or are you trying to be complete because of the README?

shawaj · 2023-04-11T20:25:27Z

@madninja yeah we only need the additional x86 one. I was trying to be helpful but have clearly done the opposite :-P

I assumed they were necessary / used as they were previously set up as targets for actual users in the makefile (and readme):
https://github.com/helium/gateway-rs/blob/2d44b5c11a6b6d80c7e5fe67ef1f94f389c7eeba/Makefile.toml

Is that not the case any more?

madninja · 2023-04-11T20:27:55Z

@madninja yeah we only need the additional x86 one. I was trying to be helpful but have clearly done the opposite :-P

I assumed they were necessary / used as they were previously set up as targets for actual users in the makefile (and readme): https://github.com/helium/gateway-rs/blob/2d44b5c11a6b6d80c7e5fe67ef1f94f389c7eeba/Makefile.toml

Is that not the case any more?

The affected makers are either not using the builds here or are no longer in business. If you want to fix them up you can but you'd have to get an updated protoc in the build images.

shawaj · 2023-04-11T20:35:31Z

ok - will keep it simple and can those two for now then 👍

thanks, as always, @madninja

have fixed and rebased

.github/workflows/ci.yml

Makefile.toml

- add ecc608 based x86_64 image - add docker builds for armv6 and armv7 - change the build and push step to use the prebuilt docker action

shawaj · 2023-04-11T20:56:29Z

I guess the build is failing because i don't have access to the repository secrets but otherwise seems to be ok...

Run docker/login-action@v2
Error: Username and password required

.github/workflows/ci.yml

helium#415

Fixes the issue in helium#415

NkkVr · 2024-03-27T22:09:05Z

cross build --target armv7-unknown-linux-musleabihf --release I have no problem with this. but cross build --target aarch64-unknown-linux-gnu --release I did not overcome the problem.

root@Helium:~/Helium/gateway-rs# cross build --target aarch64-unknown-linux-gnu --release
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
Install the buildx component to build images with BuildKit:
https://docs.docker.com/go/buildx/

Compiling helium-proto v0.1.0 (https://github.com/helium/proto?branch=master#d94ed4b4)
error: failed to run custom build command for helium-proto v0.1.0 (https://github.com/helium/proto?branch=master#d94ed4b4)

Caused by:
process didn't exit successfully: /target/release/build/helium-proto-a8c15c324ceedd69/build-script-build (exit status: 1)
--- stdout
cargo:rerun-if-changed=src/blockchain_txn.proto
cargo:rerun-if-changed=src/entropy.proto
cargo:rerun-if-changed=src/data_rate.proto
cargo:rerun-if-changed=src/region.proto
cargo:rerun-if-changed=src/mapper.proto
cargo:rerun-if-changed=src/reward_manifest.proto
cargo:rerun-if-changed=src/blockchain_region_param_v1.proto
cargo:rerun-if-changed=src/price_report.proto
cargo:rerun-if-changed=src/service/router.proto
cargo:rerun-if-changed=src/service/state_channel.proto
cargo:rerun-if-changed=src/service/local.proto
cargo:rerun-if-changed=src/service/transaction.proto
cargo:rerun-if-changed=src/service/follower.proto
cargo:rerun-if-changed=src/service/poc_mobile.proto
cargo:rerun-if-changed=src/service/poc_lora.proto
cargo:rerun-if-changed=src/service/poc_entropy.proto
cargo:rerun-if-changed=src/service/packet_router.proto
cargo:rerun-if-changed=src/service/iot_config.proto
cargo:rerun-if-changed=src/service/mobile_config.proto
cargo:rerun-if-changed=src/service/downlink.proto
cargo:rerun-if-changed=src/service/multi_buy.proto
cargo:rerun-if-changed=src/service/packet_verifier.proto
cargo:rerun-if-changed=src

--- stderr
Error: Custom { kind: Other, error: "protoc failed: blockchain_txn.proto:1:10: Unrecognized syntax identifier "proto3". This parser only recognizes "proto2".\n" }
root@Helium:/Helium/gateway-rs# protoc --version
libprotoc 3.6.1
root@Helium:/Helium/gateway-rs#

madninja · 2024-03-27T22:11:10Z

This is an issue with your build system Ge a newer version of the protocol tool that supports proto3 format.

NkkVr · 2024-03-29T11:25:37Z

So how can I solve this problem?

shawaj force-pushed the main branch 2 times, most recently from efd2063 to 8bcfbf0 Compare April 11, 2023 19:24

shawaj mentioned this pull request Apr 11, 2023

Error: Custom { kind: Other, error: "protoc failed: blockchain_txn.proto:1:10: Unrecognized syntax identifier \"proto3\". This parser only recognizes \"proto2\".\n" } helium/proto#318

Closed

shawaj force-pushed the main branch from 9873a17 to a2cfd17 Compare April 11, 2023 20:32

shawaj force-pushed the main branch from ffce7a9 to bf4a279 Compare April 11, 2023 20:36

madninja reviewed Apr 11, 2023

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

Makefile.toml Outdated Show resolved Hide resolved

feat: add builds and use prebuilt action

6ec9e0b

- add ecc608 based x86_64 image - add docker builds for armv6 and armv7 - change the build and push step to use the prebuilt docker action

shawaj force-pushed the main branch from a551097 to 6ec9e0b Compare April 11, 2023 20:52

shawaj requested a review from madninja April 11, 2023 20:57

madninja reviewed Apr 11, 2023

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

madninja approved these changes Apr 11, 2023

View reviewed changes

madninja merged commit 58f0126 into helium:main Apr 11, 2023

madninja mentioned this pull request Apr 11, 2023

CI fix #417

Closed

shawaj added a commit to shawaj/gateway-rs that referenced this pull request Apr 11, 2023

fix: error in helium#415

c1f02e7

helium#415

shawaj mentioned this pull request Apr 11, 2023

fix: error in #415 #418

Closed

shawaj added a commit to shawaj/gateway-rs that referenced this pull request Apr 11, 2023

fix: blackout armv6/ armv7 builds

753dc9c

Fixes the issue in helium#415

shawaj mentioned this pull request Apr 11, 2023

fix: backout armv6/ armv7 builds #419

Merged

shawaj added a commit to shawaj/gateway-rs that referenced this pull request Apr 11, 2023

fix: blackout armv6/ armv7 builds

4a4f978

Fixes the issue in helium#415

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add builds and use prebuilt action #415

feat: add builds and use prebuilt action #415

shawaj commented Apr 11, 2023 •

edited

Loading

shawaj commented Apr 11, 2023

madninja commented Apr 11, 2023

shawaj commented Apr 11, 2023

madninja commented Apr 11, 2023

shawaj commented Apr 11, 2023

shawaj commented Apr 11, 2023 •

edited

Loading

NkkVr commented Mar 27, 2024

madninja commented Mar 27, 2024

NkkVr commented Mar 29, 2024

feat: add builds and use prebuilt action #415

feat: add builds and use prebuilt action #415

Conversation

shawaj commented Apr 11, 2023 • edited Loading

shawaj commented Apr 11, 2023

madninja commented Apr 11, 2023

shawaj commented Apr 11, 2023

madninja commented Apr 11, 2023

shawaj commented Apr 11, 2023

shawaj commented Apr 11, 2023 • edited Loading

NkkVr commented Mar 27, 2024

madninja commented Mar 27, 2024

NkkVr commented Mar 29, 2024

shawaj commented Apr 11, 2023 •

edited

Loading

shawaj commented Apr 11, 2023 •

edited

Loading