Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(factory): Add option to supply own reqwest::Client #13

Merged
merged 1 commit into from
May 14, 2024

Conversation

dougEfresh
Copy link
Contributor

  • Add ability to supply own reqwest::Client
  • Remove Cargo.lock
  • remove solana-core (this is not needed and brings rocksdb as dependency)

@0xIchigo 0xIchigo self-requested a review May 13, 2024 18:13
Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very based! I just have the formatting and adding the Cargo.lock to the gitignore as nitpicks, but overall really solid!

tests/test_factory.rs Outdated Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
@0xIchigo 0xIchigo changed the title feat(factory): Add option to supply own reqwest::Client feat(factory): Add option to supply own reqwest::Client May 14, 2024
Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@0xIchigo 0xIchigo merged commit 6b985e9 into helius-labs:dev May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants