Biome (the new official fork of Rome) language server is giving log errors, is this something to report to the devs? Any input welcome!

[David-Else]

I am trying to configure https://github.com/biomejs/biome/ and update their Helix config page biomejs/biome#1031. I get the following in the Helix log. It mentions Please report this upstream to the language server, but I am not sure what to report, if anything.

Biome not seem to want to use the LSP formatting, but the linting seems to work well, I assume that is because of unsupported method: textDocument/formatting?

UPDATE: I found this info: biomejs/biome#87

Biome does support formatting via LSP. It's possible that your client is not able to register to this event because it doesn't support dynamic registration of the events

Does Helix support dynamic registration of the events?

It is a great project, I recommend people check it out, you should be able to dump eslint with all its config cruft:

 sudo npm install -g @biomejs/biome

[language-server]
biome = { command = "biome", args = ["lsp-proxy"] }

[[language]]
name = "javascript"
auto-format = true
language-servers = ["typescript-language-server", "biome"]

[[language]]
name = "typescript"
auto-format = true
language-servers = ["typescript-language-server", "biome"]

[[language]]
name = "tsx"
auto-format = true
language-servers = ["typescript-language-server", "biome"]

[[language]]
name = "jsx"
auto-format = true
language-servers = ["typescript-language-server", "biome"]

[[language]]
name = "json"
language-servers = ["vscode-json-language-server", "biome"]

2023-12-04T12:46:16.529 helix_term::application [WARN] Received unregistration request for unsupported method: workspace/didChangeConfiguration
2023-12-04T12:46:16.529 helix_term::application [WARN] Received unregistration request for unsupported method: textDocument/rangeFormatting
2023-12-04T12:46:16.529 helix_term::application [WARN] Received unregistration request for unsupported method: textDocument/onTypeFormatting
2023-12-04T12:46:16.529 helix_term::application [WARN] Received unregistration request for unsupported method: textDocument/rename
2023-12-04T12:46:16.529 helix_term::application [WARN] Received unregistration request for unsupported method: textDocument/formatting
2023-12-04T12:46:16.530 helix_term::application [WARN] Ignoring a client/registerCapability request because dynamic capability registration is not enabled. Please report this upstream to the language server
2023-12-04T12:46:16.530 helix_term::application [WARN] Ignoring a client/registerCapability request because dynamic capability registration is not enabled. Please report this upstream to the language server
2023-12-04T12:46:16.530 helix_term::application [WARN] Ignoring a client/registerCapability request because dynamic capability registration is not enabled. Please report this upstream to the language server

[the-mikedavis]

Currently we only support dynamic registration for didChangeWatchedFiles but biome is sending them for other methods too.

You can try this patch for foratting for example:

diff --git a/helix-lsp/src/client.rs b/helix-lsp/src/client.rs
index e6e1f8a0..949683a0 100644
--- a/helix-lsp/src/client.rs
+++ b/helix-lsp/src/client.rs
@@ -645,6 +645,9 @@ pub(crate) async fn initialize(&self, enable_snippets: bool) -> Result<lsp::Init
                         dynamic_registration: Some(false),
                         resolve_support: None,
                     }),
+                    formatting: Some(lsp::DocumentFormattingClientCapabilities {
+                        dynamic_registration: Some(false),
+                    }),
                     ..Default::default()
                 }),
                 window: Some(lsp::WindowClientCapabilities {

but I believe unless we explicitly say we enable dynamic registration for a method by passing dynamic_regsitration: true there then the server should not be sending us client/registerCapability requests for that method.

[Awesomerly]

I might try with the provided config and if that doesn't work i might wanna snag the master branch.. I'm on stable

[Awesomerly]

I just tried with both and neither were able to get the formatting working. Do I need a biome.json for the formatting to work?

[Awesomerly]

2024-01-23T09:51:58.990 helix_term::application [WARN] can't find language server with id `1`
2024-01-23T09:51:58.993 helix_lsp::transport [ERROR] typescript-language-server err: <- StreamClosed
2024-01-23T09:51:58.996 helix_lsp::transport [ERROR] biome err: <- StreamClosed
2024-01-23T09:51:59.286 helix_term::application [WARN] Received unregistration request for unsupported method: workspace/didChangeConfiguration
2024-01-23T09:51:59.286 helix_term::application [WARN] Received unregistration request for unsupported method: textDocument/rangeFormatting
2024-01-23T09:51:59.286 helix_term::application [WARN] Received unregistration request for unsupported method: textDocument/onTypeFormatting
2024-01-23T09:51:59.286 helix_term::application [WARN] Received unregistration request for unsupported method: textDocument/rename
2024-01-23T09:51:59.286 helix_term::application [WARN] Received unregistration request for unsupported method: textDocument/formatting
2024-01-23T09:51:59.286 helix_term::application [WARN] Ignoring a client/registerCapability request because dynamic capability registration is not enabled. Please report this upstream to the language server
2024-01-23T09:51:59.286 helix_term::application [WARN] Ignoring a client/registerCapability request because dynamic capability registration is not enabled. Please report this upstream to the language server
2024-01-23T09:51:59.286 helix_term::application [WARN] Ignoring a client/registerCapability request because dynamic capability registration is not enabled. Please report this upstream to the language server

this is what my log looks like. I don't know why but the first line only appeared once

[Awesomerly]

https://gist.github.com/Awesomerly/9e4eb89ab9b97254eb67fa310376d6ba

here are my biome logs

[brielov]

I think I'm having trouble as well. I just copied the official languages.toml file onto my computer and it doesn't seem to want to format files when saving a buffer. I first tried adding it to my own config and then with only the suggested config and no luck.

[Awesomerly]

I tried only specifying biome and it doesn't format when I do that either.

[brielov]

Any news on this? Still can't use helix + biome

[ghost]

I've got helix + biome working with the following setup:

[language-server]
biome = { command = "biome", args = ["lsp-proxy"] }
emmet-ls = { command = "emmet-ls", args = [ "--stdio" ]}

#---------------------------------------------------------------------------------------------------------

[[language]]
name = "javascript"
language-servers = [
  { name = 'biome' },
  { name = 'typescript-language-server', except-features = ['format'] }
]
auto-format = true
formatter = { command = "biome", args = ["format", "--stdin-file-path", "a.js"] }

#---------------------------------------------------------------------------------------------------------

[[language]]
name = "typescript"
language-servers = [
  { name = 'biome' },
  { name = 'typescript-language-server', except-features = ['format'] }
]
auto-format = true
formatter = { command = "biome", args = ["format", "--stdin-file-path", "a.ts"] }

#---------------------------------------------------------------------------------------------------------

[[language]]
name = "jsx"
language-servers = [
  { name = 'biome' },
  { name = 'emmet-ls' },
  { name = 'typescript-language-server', except-features = ['format'] }
]
auto-format = true
formatter = { command = "biome", args = ["format", "--stdin-file-path", "a.jsx"] }

#---------------------------------------------------------------------------------------------------------

[[language]]
name = "tsx"
language-servers = [
  { name = 'biome' },
  { name = 'emmet-ls' },
  { name = 'typescript-language-server', except-features = ['format'] }
]
auto-format = true
formatter = { command = "biome", args = ["format", "--stdin-file-path", "a.tsx"] }

Biome installed globally and a 'biome.jsonc' in your project directory, e.g.:

{
	"$schema": "https://biomejs.dev/schemas/1.6.2/schema.json",
	"organizeImports": {
		"enabled": true
	},
	"linter": {
		"enabled": true,
		"rules": {
			"recommended": true,
			"style": {
				"noNonNullAssertion": "off"
			}
		}
	},
	"formatter": {
		"enabled": true,
		"formatWithErrors": false,
		"indentStyle": "tab",
		"indentWidth": 2,
		"lineWidth": 80,
		"lineEnding": "lf",
		"ignore": []
	}
}

Tested on SolidJS and React projects - linting and formatting both work.

[brielov]

Thanks, that worked! It is a nice workaround although I'd still like to be usable just from the lsp, like deno does. Anyway, thanks!

[SufianBabri]

Strangely I was getting this same error but neither the formatter nor the linter was working. The solution proposed by ghost fixed the formatter but the linter issue remained.

No solution worked (closing and launching Kitty instance again didn't do anything either). I rebooted my system and everything is working awesome again. I removed the formatter lines suggested by ghost and it still works. Strange.

[pincscrawfor]

If you don't install biome globablly, this should work instead

[language-server]
biome = { command = "npx", args = ["biome", "lsp-proxy"] }