Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theming for primary cursor and/or selection in themes that lack them #1833

Open
Omnikar opened this issue Mar 18, 2022 · 3 comments
Open
Labels
A-theme Area: Theme and appearence related

Comments

@Omnikar
Copy link
Contributor

Omnikar commented Mar 18, 2022

Some of the themes in runtime/themes make no distinction between primary and other cursors/selections; this, I think, should be addressed to prevent confusions like #1780 and in order to let people using said themes to make full use of the multiple cursors system.

List of themes that do not distinguish between primary and nonprimary cursors/selections:

  • bogster
  • ingrid
  • rose_pine
  • rose_pine_dawn
  • serika-light *in making this list, I've realized that these two theme names mistakenly use hyphens instead of underscores
  • serika-dark
  • everforest_light
  • everforest_dark
@CptPotato
Copy link
Contributor

CptPotato commented Mar 18, 2022

I agree with this, but maybe #1337 should be resolved first?

Since cursor.primary sets the color for both INS and NOR mode I didn't use it in my themes. Distinguishing between NOR/INS/VIS mode was more important to me.

@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Mar 18, 2022
@LollipopFt
Copy link
Contributor

@Omnikar not sure if it's me, but gruvbox, dark_plus, monokai, onedark, spacebones_light, base16_default seem to have the same problem.

@Omnikar
Copy link
Contributor Author

Omnikar commented Mar 21, 2022

I just checked through those, and they seem to fall into two categories:

gruvbox, spacebones_light
These themes provide a theming for the primary cursor, but it is very similar to the normal cursor theme, and hard to notice.

dark_plus, monokai, onedark, base16_default
These themes don't provide a theming for the primary cursor, but do provide a theming for the primary selection, meaning you can distinguish cursors only if they have selections with them.

AlexanderBrevig added a commit to AlexanderBrevig/helix that referenced this issue Sep 14, 2022
pickfire added a commit that referenced this issue Sep 19, 2022
* feat: cargo xtask themelint <theme>

* fix: add docs and print json error status

* fix: refactor paths -> path

* fix: remove unused function

* fix: only report one err per scope (ui.statusline is reported if none of ui.statusline.* is recognized)

* fix: save work for later

* fix: finally decided on a design

* fix: ready for discussion

* fix: better rules

* fix: lint precision

* fix: String -> &'static str

* fix: allowlist not denylist for file type

* fix: add missing and indication of what's needed

* fix: copy pasteable errors

* fix: use Loader:read_names

* Update xtask/src/helpers.rs

Co-authored-by: Ivan Tham <pickfire@riseup.net>

* fix: remove into and clone for str

* Update book/src/themes.md

Co-authored-by: Ivan Tham <pickfire@riseup.net>

* fix: better lint output

* fix: cleaner logic for lint reporting

* style: use explicit imports

* Pascal support (#3542)

* fix: add difference check for statusline normal,insert,select

* fix: fg for whitespace and early exit if and one is ok

* chore: cleaning up, no idea how these got here or how this will look

* chore: revert from older commit?

* refactor: use static fn to equalize api between difference and existance

* refactor: querycheck and clippy

* refactor: clippy fixes

* fix: query-check behaves as before

* fix: error with x of y message, not total count

* fix: consistent reporting and less mutable state

* fix: selection difference ref #3942 ref #1833

Co-authored-by: Ivan Tham <pickfire@riseup.net>
Co-authored-by: ath3 <45574139+ath3@users.noreply.github.com>
herkhinah pushed a commit to herkhinah/helix that referenced this issue Dec 11, 2022
* feat: cargo xtask themelint <theme>

* fix: add docs and print json error status

* fix: refactor paths -> path

* fix: remove unused function

* fix: only report one err per scope (ui.statusline is reported if none of ui.statusline.* is recognized)

* fix: save work for later

* fix: finally decided on a design

* fix: ready for discussion

* fix: better rules

* fix: lint precision

* fix: String -> &'static str

* fix: allowlist not denylist for file type

* fix: add missing and indication of what's needed

* fix: copy pasteable errors

* fix: use Loader:read_names

* Update xtask/src/helpers.rs

Co-authored-by: Ivan Tham <pickfire@riseup.net>

* fix: remove into and clone for str

* Update book/src/themes.md

Co-authored-by: Ivan Tham <pickfire@riseup.net>

* fix: better lint output

* fix: cleaner logic for lint reporting

* style: use explicit imports

* Pascal support (helix-editor#3542)

* fix: add difference check for statusline normal,insert,select

* fix: fg for whitespace and early exit if and one is ok

* chore: cleaning up, no idea how these got here or how this will look

* chore: revert from older commit?

* refactor: use static fn to equalize api between difference and existance

* refactor: querycheck and clippy

* refactor: clippy fixes

* fix: query-check behaves as before

* fix: error with x of y message, not total count

* fix: consistent reporting and less mutable state

* fix: selection difference ref helix-editor#3942 ref helix-editor#1833

Co-authored-by: Ivan Tham <pickfire@riseup.net>
Co-authored-by: ath3 <45574139+ath3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

No branches or pull requests

4 participants