Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow max number of files used by file_picker to be configurable #5157

Closed
nstinus opened this issue Dec 14, 2022 · 1 comment
Closed

Allow max number of files used by file_picker to be configurable #5157

nstinus opened this issue Dec 14, 2022 · 1 comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@nstinus
Copy link

nstinus commented Dec 14, 2022

It is currently an undocumented hard coded value. Allowing it to be configurable has the benefit of documenting it and allowing users to set a greater value. Perhaps with a warning that bad performance could be expected?

const MAX: usize = 100_000;

@pascalkuthe
Copy link
Member

This was adreased by #7814, there is no limit anymore, files are streamed into the picker in the background now (and the matcher ks fast enough to handle millions of files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
3 participants