Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide appstream metadata file. #5624

Closed
blt-r opened this issue Jan 21, 2023 · 2 comments
Closed

Provide appstream metadata file. #5624

blt-r opened this issue Jan 21, 2023 · 2 comments
Labels
A-packaging Area: Packaging and bundling C-enhancement Category: Improvements

Comments

@blt-r
Copy link
Contributor

blt-r commented Jan 21, 2023

Currently the flatpak package of the Helix uses a basic .appdata.xml file written by the packager (me). Ideally that file should be provided by the app itself. Not only that is the best practice for flathub, that will mean that other packages will be able to use it as well. For example if it will be added to archlinux-appstream-data then software stores on arch linux would be able to recognize it.

Currently on archlinux in gnome-software if you search for "Helix" two things will come up:
Screenshot from 2023-01-21 23-36-52

One is the version from arch repositories that gets all the info from .desktop file:
Screenshot from 2023-01-21 23-36-56

And the other from flathub with the .appdata.xml that I wrote:
Screenshot from 2023-01-21 23-40-07

If all packages would all use .appdata.xml file, software stores could understand that it is the same package. Also current page for native version of the package doesn't have much. No screenshots, not much description, and no licensing information (gnome software marks it as proprietary for that reason). Providing the appstream manifest would also allow you to add more stuff like release notes. (now when I'm looking at it this manifest is really minimal, I could easily add more links, keywords, categories, the video)

We can start by just copying the manifest I wrote into ./contrib/Helix.appdata.xml and put Helix.desktop instead of the flatpak-specific com.helix_editor.Helix.desktop. Also probably replace the license for the metadata file with the one used for this repo.

@blt-r blt-r added the C-enhancement Category: Improvements label Jan 21, 2023
@the-mikedavis the-mikedavis added the A-packaging Area: Packaging and bundling label Jan 21, 2023
@pascalkuthe
Copy link
Member

This sounds reasonable to me. Since you arleardy worked om this you could look into sending a PR if you feel up to it

@pascalkuthe
Copy link
Member

I am closing this as #5643 was already merged and the issues just didn't get picked up by github automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

3 participants