Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appstream metadata file #5643

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Add Appstream metadata file #5643

merged 6 commits into from
Jan 24, 2023

Conversation

blt-r
Copy link
Contributor

@blt-r blt-r commented Jan 23, 2023

For #5624.

In the future when new release is out we should add

<release version="23.12" date="2004-12-07" />

or maybe even something like

<release version="23.12" date="2004-12-07">
  <description>
    <p>"X = 'extend_line_above'" is now the default!</p>
  </description>
  <url>https://helix-editor.com/news/release-23-12-highlights/</url>
</release>

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a bullet for updating this file between these two bullets in the release docs?

* Merge the changelog PR
* Tag and push

contrib/Helix.appdata.xml Outdated Show resolved Hide resolved
blt-r and others added 2 commits January 23, 2023 20:08
@blt-r
Copy link
Contributor Author

blt-r commented Jan 23, 2023

Maybe it would be a good idea to link the spec somewhere? Just for future reference

@the-mikedavis
Copy link
Member

Would the appdata file allow comments? I think it would be good to link it near the top of the file if comments won't mess up the appdata parsing

<content_rating type="oars-1.1" />

<releases>
<release version="22.12" date="2022-12-6" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the whole list of prior releases be included too? Or just starting from 22.12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might include every release and link to the blog post. While not necessary, it's probably a good idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the ones that have blog posts

@the-mikedavis the-mikedavis added A-packaging Area: Packaging and bundling S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 23, 2023
@blt-r
Copy link
Contributor Author

blt-r commented Jan 23, 2023

Would the appdata file allow comments? I think it would be good to link it near the top of the file if comments won't mess up the appdata parsing

I mean in the releases.md. I'll add a commit

@the-mikedavis the-mikedavis merged commit 91dca3f into helix-editor:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants