Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection mode persists after commenting #597

Closed
yerlaser opened this issue Aug 16, 2021 · 0 comments · Fixed by #598
Closed

Selection mode persists after commenting #597

yerlaser opened this issue Aug 16, 2021 · 0 comments · Fixed by #598
Labels
C-bug Category: This is a bug

Comments

@yerlaser
Copy link
Contributor

Reproduction steps

  1. Enter selection mode with "v"
  2. Press "j" multiple times to select several lines
  3. Press a key sequence that is configured to comment line(s) of code
  4. Press "j" or "k"
  5. Observe that the selection mode is still on

Environment

  • Platform: Linux
  • Helix version: v0.4.1-5-g4b5090a

I know that in recent version yanking resets mode to normal. Would be good if same happens after commenting lines.
@yerlaser yerlaser added the C-bug Category: This is a bug label Aug 16, 2021
@yerlaser yerlaser mentioned this issue Aug 16, 2021
Merged
archseer pushed a commit that referenced this issue Aug 17, 2021
@yerlaser
Exit select mode after toggle_comment. Fixes #597 (#598)
18c0509 
Consistent with yanking, exit select mode after toggling comment. Fixes #597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exit select mode after toggle_comment. Fixes #597
1 participant
@yerlaser