Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor scroll past buffer for CJK characters #840

Closed
pickfire opened this issue Oct 14, 2021 · 0 comments · Fixed by #885
Closed

Cursor scroll past buffer for CJK characters #840

pickfire opened this issue Oct 14, 2021 · 0 comments · Fixed by #885
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@pickfire
Copy link
Contributor

pickfire commented Oct 14, 2021 •
edited
Loading

This is probably a regression, I don't recall seeing this issue in the past. Maybe after the great line ending changes it broke cc @cessen. Tried doing a bisect but I can't build earlier versions (0.3.0, 0.4.0, 0.4.1).

Reproduction steps

j... or gl, the cursor can scroll past the buffer if the line contains CJK characters.

Screenshot_20211014_113554

Environment

  • Platform: arch linux
  • Helix version: v0.4.1-190-gaf08f82 (paragraph branch but it should be the same in master)
@pickfire pickfire added the C-bug Category: This is a bug label Oct 14, 2021
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Oct 14, 2021
pickfire added a commit to pickfire/helix that referenced this issue Oct 20, 2021
@pickfire
Ensure coords in screen depends on char width
0bd90ff 
The issue affected files with lots of tabs at the start as well.

Fix helix-editor#840
@pickfire pickfire mentioned this issue Oct 20, 2021
Merged
pickfire added a commit to pickfire/helix that referenced this issue Oct 21, 2021
@pickfire
Ensure coords in screen depends on char width
e0c152d 
The issue affected files with lots of tabs at the start as well.

Fix helix-editor#840
pickfire added a commit to pickfire/helix that referenced this issue Oct 25, 2021
@pickfire
Ensure coords in screen depends on char width
5c73f2d 
The issue affected files with lots of tabs at the start as well.

Fix helix-editor#840
pickfire added a commit to pickfire/helix that referenced this issue Oct 29, 2021
@pickfire
Ensure coords in screen depends on char width
c04e405 
The issue affected files with lots of tabs at the start as well.

Fix helix-editor#840
archseer pushed a commit that referenced this issue Nov 3, 2021
@pickfire
Ensure coords in screen depends on char width (#885)
3eb829e 
The issue affected files with lots of tabs at the start as well.

Fix #840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure coords in screen depends on char width pickfire/helix
2 participants
@pickfire @kirawi