-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show newest options in jumplist picker first, fix docs #10095
Conversation
the rest lgtm but I don't think this should be added here. If we are going to do this it should be a separate column as part of #9647 but I am even critical of that. What is your usecase here. I don't think people generally search by line (if you already know the line why bother searching). We could show gutters with line number instead (may be nice for diff gutter aswell) but that also takes up more vertical space |
It's hard to explain, you have to feel it. Helped me on a large codebase without Lsp. But as I said, these are just my preferences, I can live without it on master.
This will work for me too. For now, I can remove it and maybe create an issue to request config option: "line numbers in pickers" so that all possible pickers are consistent (jumplist, buffer, symbol, etc). Then you will decide whether this feature has the right to live. |
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
…10095) * docs: mention `<space>g` changed file picker * picker(jumplist): show jumps in order from latest to oldest
These are a few patches I've collected while using Helix. Let the world finally see them.
commit 94db151 : docs: mention
<space>g
changed file picker. This was missed in the #5645These two are personal preferences, but I think they're fair:
commit a4b5b4c : picker(jumplist): show newest options on top instead of bottom
commit ef13bf5 : picker(global-search): append line number to found optionsYou can reject them all, select only docs commit, or do whatever you want :)