Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable metals inlay hints #10597

Merged

Conversation

keirlawson
Copy link
Contributor

By default Metals does not enable inlay hints, enabling support means that whether they are displayed is then in control of the editor.

@zetashift
Copy link
Contributor

Is it wise to enable this by default? Inlay hints usage in Helix have an asterisk: https://docs.helix-editor.com/configuration.html?highlight=inlay#2 and are disabled by default.
I wonder if mentioning this config option in the wiki is a decent stopgap solution?

@pascalkuthe
Copy link
Member

enableing these by default in the language server config doesn't do anything until helix actually requests them. So for people that have their inlay hint setting disabled this doesn't change anything

@the-mikedavis the-mikedavis merged commit 31248d4 into helix-editor:master Apr 26, 2024
6 checks passed
@keirlawson keirlawson deleted the enable-metals-inlay-hints branch April 26, 2024 22:03
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
Chirikumbrah pushed a commit to Chirikumbrah/helix that referenced this pull request Jun 15, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants