fix: correctly reset inlay hints when stopping or restarting LSPs for a document #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
added
A-language-server
poliorcetics
force-pushed
the
ab/push-yuopnrvpvntp
branch
from
23fb16a
to
1dee34e
Compare
poliorcetics
force-pushed
the
ab/push-yuopnrvpvntp
branch
from
1dee34e
to
41351e9
Compare
pascalkuthe
approved these changes
May 31, 2024
|
The test failure is unrelated to this MR (or I'm very confused) |
the-mikedavis
approved these changes
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopping or restarting an LSP currently does not cleanup the inlay hints for the documents.
They're correctly recomputed later in the restart case if the restarted LSP supports them: changing the binary and restarting can change that behaviour (e.g. after an update, which is reason to call
:lsp-restarton an open document)