Large Gruvbox refactoring

[Chirikumbrah]

Not so long ago I completely switched from Dracula to Gruvbox and I decided to make it more comfortable according to NVim Gruvbox colors.

I changed operator color with some other colors and disabled some bold fonts:

I also improved cursor/cursorline colors and made cursor color the same as the mode color. You can notice that primary cursorline is a bit lighter:

• Normal mode with multicursor:
  

• Selection mode with multicursor:
  

• Insert mode with multicursor:
  

---

Now, diagnostics:
I decided to choose diagnostics colours according to their severity level:

• Hint - aqua
  

• Info - yellow
  Sorry for no image but I didn't find any examples :)

• Warning - orange and Error - red
  

---

I hope you will like theese changes and I am open to your improvements :)

[justinesmithies]

Nice ! I use gruvbox and that is an improvement indeed.
Fingers crossed it's accepted.

[Locorock]

A few things that left me puzzled about this:

• How does this affect downstream themes like gruvbox light?
• I'm pretty sure you should merge refactor(themes): gruvbox warnings to yellow1 #10506
• shouldn't we base this theme off https://github.com/morhetz/gruvbox rather than https://github.com/ellisonleao/gruvbox.nvim?
• if you're basing this off neovim gruvbox, why are you removing bold functions?

Now for some personal opinions:

• diagnostics for hints/warnings have mismatched colors
• dimming text for warning makes spotting errors really hard, this is even worse for the light theme
• rust variables end up getting colored when used in expressions, not sure if this is intended or not
• operators being the same color of operands makes code less legible
• there are also some oddities with diagnostic priority which i wasn't able to pinpoint, not sure if this is the theme's fault

[Chirikumbrah]

How does this affect downstream themes like gruvbox light? Also i'm pretty sure you should merge #10506

I think orange is more suitable for warnings and yellow for infos, so I will change colors there.

[Locorock]

How does this affect downstream themes like gruvbox light? Also i'm pretty sure you should merge #10506

I think orange is more suitable for warnings and yellow for infos, so I will change colors there.

that would be the case but red and orange are quite hard to differentiate in gruvbox (especially with the light theme)

[Chirikumbrah]

• operators being the same color of operands makes code less legible

I brought the purple1 back)

[Chirikumbrah]

• if you're basing this off neovim gruvbox, why are you removing bold functions?

Because I didn't notice that functions are bold in the gruvbox.nvim and for me it is not so convinient. NeoVim's example below)

[Chirikumbrah]

• dimming text for warning makes spotting errors really hard, this is even worse for the light theme

Only unnecessary objects are dimmed)

• diagnostics for hints/warnings have mismatched colors
• rust variables end up getting colored when used in expressions, not sure if this is intended or not
• there are also some oddities with diagnostic priority which i wasn't able to pinpoint, not sure if this is the theme's fault

I agree, but could you please suggest some better solutions for some colors?
To be honest I don't know the better way to prioritize diagnostics colors, but yes, in the light themes orange and red are quite the same.

And thank you for your participation :)

[Chirikumbrah]

• I'm pretty sure you should merge refactor(themes): gruvbox warnings to yellow1 #10506

The main question for me in this case is will it be ok if I set yellow for warnings and aqua for both hints and infos?)

[Locorock]

I agree, but could you please suggest some better solutions for some colors? To be honest I don't know the better way to prioritize diagnostics colors, but yes, in the light themes orange and red are quite the same.

I think the current diagnostic colors are fine:

• Red for errors
• Yellow for warnings
• Aqua for hints
• Blue for info

Now the real question becomes how do we handle diagnostic information which is not in the original theme, namely Unnecessary and Deprecated:

• Deprecated seems straightforward enough, strikethrough seems like a standard at this point
• Unnecessary is a bit more complex, adding dimming might be fine but, talking about gutter dots here, helix considers unnecessary diagnostics as warnings, so the colors are always going to be mismatched. Realistically speaking i think we're better off leaving unnecessary diagnostics with the default behaviour, at least until helix handles gutter diagnostics correctly.

[Chirikumbrah]

• Red for errors
• Yellow for warnings
• Aqua for hints
• Blue for info

Made so, but aqua for info and blue for hints as it was before :)

• i think we're better off leaving unnecessary diagnostics with the default behaviour

I commented this line for future changes.

• shouldn't we base this theme off https://github.com/morhetz/gruvbox rather than https://github.com/ellisonleao/gruvbox.nvim?

Probably we should, by the way, but I used gruvbox theme only with NeoVim. Not Vim. So for me it's easier to compare this theme with NeoVim's implementation.
If you have any additional suggestions, I'd be happy to discuss them)

[Chirikumbrah]

@Locorock, I also set diff.delta color to yellow as for the color of warnings :)

[Chirikumbrah]

@archseer, @kirawi
What do you think about my PR?)
Merge please when you'll have a time if everything is fine :)