Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest *.desktop for AppImage #10823

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Conversation

Rudxain
Copy link
Contributor

@Rudxain Rudxain commented May 27, 2024

Since the official AppImage doesn't include the icon/logo/isotype, and some desktop environments (such as GNOME) don't allow executing arbitrary files by double-clicking (for security reasons), I believe it's beneficial for the user to have the .desktop shortcut file

@Rudxain
Copy link
Contributor Author

Rudxain commented May 27, 2024

BTW, it would be nice if shell completions were documented, because AppImage users might want it, and (AFAIK) following the docs doesn't install any completion

@Rudxain
Copy link
Contributor Author

Rudxain commented May 27, 2024

related: #4159

@krish-r
Copy link
Contributor

krish-r commented May 27, 2024

Minor suggestions: (Please feel free to ignore)

  • It'll be better to avoid the temp variable ($d) to avoid any potential overwrites.
    (Also, fish for ex. does not support var=val or unset)

  • Instead of suggesting this as a pre-requisite for desktop shortcut, can this be something like -
    "To run / start Helix from anywhere, make sure to add it to your $PATH".

  • Also, I think it'll be better to keep the same link text for consistency (might also be easy during the search) -
    "You can also optionally Configure the desktop shortcut".

@the-mikedavis the-mikedavis added the A-documentation Area: Documentation improvements label Jun 3, 2024
book/src/package-managers.md Outdated Show resolved Hide resolved
book/src/package-managers.md Outdated Show resolved Hide resolved
book/src/package-managers.md Outdated Show resolved Hide resolved
Rudxain and others added 4 commits July 6, 2024 12:52
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
remove `&&`

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
@the-mikedavis the-mikedavis merged commit 7ee66c0 into helix-editor:master Nov 20, 2024
6 checks passed
@Rudxain Rudxain deleted the patch-1 branch November 21, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants