Add clipboard provider configuration

[AlfGalf]

This change adds the clipboard-provider setting to the editor section of configuration.

This option can have values of:

• none (use an internal buffer) (on windows only)
• windows (use native windows clipboard) (on MacOS only)
• macos (use pbcopy/pbpaste) (on neiter of the above)
• wayland
• xclip
• xsel
• win23yank (for wsl) (on all targets with "term")
• termux
• tmux
• term (osc codes)
• custom (see below for the configuration)

Note for a custom provider the configurations should look like:

[editor.clipboard-provider.config]
copy = ["tee", "test.txt"]
paste = ["cat", "test.txt"]
primary-copy = ["tee", "test-primary.txt"] # optional
primary-copy = ["cat", "test-primary.txt"] # optional

This can be configured at runtime with the usual:

set clipboard-provider term

Note: I was unable to work out a syntax expression for setting a custom provider at runtime. In my opinion this is probably a fine limitation to have but I am curious if there is a correct way I couldn't work out.

This ports over the previous provider selection logic so hopefully the same default behaviour should apply.

I updated the health command to reflect the provider. Note: this required reading the user configurations within the health command which warrants discussion as this seems to not have been done before.

This is my first contribution, I am a C++ developer by profession and a rust hobyist at best so nits and style updates very welcome.

Note: This adds the nonempty crate as a new dependency. This is because I wanted a way to fail parsing custom commands if they were empty and didn't want to write custom parsign Serde code. I do not know what the process is for considering new dependencies and am very willing to change this for an alternative solution when presented with a better one! I looked for a serde annotation as I thought that was likely but couldn't find one.

[AlfGalf]

Predictably it wont build on machines other than mine 🙃. I'm going to look into cross compiling and clean this up

[AlfGalf]

Okay as far as I can tell this is working on Windows, Ubuntu, and MacOS

[AlfGalf]

This is a fix for #8826 by the way

[markstos]

I would personally put even fewer defaults in the core: target covering 80 to 95% of users. So: Mac, Windows, X11, Wayland, maybe term... and that's it? Once the plugin system is online, I imagine people will be able to provide plugins that support less common options.

[AlfGalf]

I would personally put even fewer defaults in the core: target covering 80 to 95% of users. So: Mac, Windows, X11, Wayland, maybe term... and that's it? Once the plugin system is online, I imagine people will be able to provide plugins that support less common options.

Ive matched the previous modes and default behavior.
I would be hesitant to remove any supported mode as that may create regressions for users. (Though maybe that comes from too much compiler development)

[AlfGalf]

Ping for this PR?
Do I need to do anything to request reviews?

[kirawi]

There's nothing you need to do. It seems like two of the main maintainers are away from Helix right now, so you may have to wait a little.

[AlfGalf]

There's nothing you need to do. It seems like two of the main maintainers are away from Helix right now, so you may have to wait a little.

Ahhh okay great thank you

[the-mikedavis]

I believe this will reset the internal buffers (within NoneProvider for example) when you reload config even if you don't change your clipboard config. I'm not sure there's an easy way to fix this though. We could consider a much larger refactor for clipboard providers to remove state from the clipboard providers (since we store yanks and pastes on the Registers type anyways), and probably remove the clipboard provider trait and just use the enum directly. I'm not sure how large of a change this would take though - I will try out some changes locally and revisit this

[AlfGalf]

Yeah, I can think of some gross solutions to this, but this seemed like the least bad option?

[AlfGalf]

Sorry for the delay, Ive been traveling, I will try address those comments!

[AlfGalf]

Just rebased this onto master

[AlfGalf]

Ping?

[AlfGalf]

I have made the required changes so I think the "waiting on author" isn't correct

[the-mikedavis]

The current tag is waiting-on-review

[AlfGalf]

Oh my apologies! I completely misread the log

[AlfGalf]

Rebased this to master

[AlfGalf]

I have also added documentation for this option.

[AlfGalf]

Ahh yes, makes sense, resolved

[sbromberger]

Just FYI, I tested this using blink.sh (ipad) over mosh and tmux, with provider termcode and it works perfectly. Thank you!

[AlfGalf]

Just FYI, I tested this using blink.sh (ipad) over mosh and tmux, with provider termcode and it works perfectly. Thank you!

Awesome! I'm really glad to hear it!

[sbromberger]

Any chance this could be merged? I've been using it for a week or so and have come to rely on it for clipboard access.

[the-mikedavis]

Looks great, thanks for working on this @AlfGalf! It ended up being a larger refactor than was strictly necessary to make config possible but I really like the way we have clipboard.rs laid out now.

[AlfGalf]

Thanks for the help with it @the-mikedavis, it's been really fun and educational, I do still have a plan for a hideous asynchronous parsing patch but that will wait until work has quietened down.

[sbromberger]

Thank you!!

[llakala]

After an update to my flake inputs, the default value here doesn't seem to be properly set. It should be using wl-copy, but pasting was simply doing nothing. I've since reverted to an older commit before this, but I can try to get some more replication info.

Edit: can confirm it's this commit specifically that breaks it.

[the-mikedavis]

Ah I see the issue, yank and paste commands are swapped. It's a bit unintuitive because to yank from the clipboard we want the clipboard program to paste and to paste we want it to yank.

[llakala]

Ah I see the issue, yank and paste commands are swapped. It's a bit unintuitive because to yank from the clipboard we want the clipboard program to paste and to paste we want it to yank.

Working great now! Thanks for the quick fix.