Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unicode-general-category with icu-properties #10989

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Replace unicode-general-category with icu-properties #10989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion helix-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ smallvec = "1.13"
smartstring = "1.0.1"
unicode-segmentation = "1.11"
unicode-width = "0.1"
unicode-general-category = "0.6"
icu_properties = "1.5"
slotmap.workspace = true
tree-sitter.workspace = true
once_cell = "1.19"
Expand Down
4 changes: 2 additions & 2 deletions helix-core/src/chars.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ pub fn char_is_whitespace(ch: char) -> bool {

#[inline]
pub fn char_is_punctuation(ch: char) -> bool {
use unicode_general_category::{get_general_category, GeneralCategory};
use icu_properties::{maps::general_category, GeneralCategory};

matches!(
get_general_category(ch),
general_category().get(ch),
GeneralCategory::OtherPunctuation
| GeneralCategory::OpenPunctuation
| GeneralCategory::ClosePunctuation
Expand Down
2 changes: 1 addition & 1 deletion helix-core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ mod transaction;
pub mod wrap;

pub mod unicode {
pub use unicode_general_category as category;
pub use icu_properties as properties;
pub use unicode_segmentation as segmentation;
pub use unicode_width as width;
}
Expand Down
Loading