Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for cylc configuration files #11830

Merged
merged 7 commits into from
Oct 30, 2024
Merged

feat: Add support for cylc configuration files #11830

merged 7 commits into from
Oct 30, 2024

Conversation

elliotfontaine
Copy link
Contributor

Cylc (pronounced silk) is a general purpose workflow engine that also manages cycling systems very efficiently. It is used in production weather, climate, and environmental forecasting on HPC, but is not specialized to those domains.

Cylc

Configurations are the main filetype of Cylc, as they're used to define workflows (tasks and their dependencies).

the-mikedavis
the-mikedavis reviewed Oct 6, 2024
View reviewed changes
runtime/queries/cylc/injections.scm Outdated Show resolved Hide resolved
runtime/queries/cylc/injections.scm Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Oct 6, 2024
the-mikedavis
the-mikedavis reviewed Oct 8, 2024
View reviewed changes
runtime/queries/cylc/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/cylc/highlights.scm Outdated Show resolved Hide resolved
the-mikedavis
the-mikedavis previously approved these changes Oct 9, 2024
View reviewed changes
@elliotfontaine
Copy link
Contributor Author

Hi @the-mikedavis.
Should I squash the commits now or wait for the second review ?

@the-mikedavis
Copy link
Member

We can squash as we merge so let's wait for another reviewer

@pascalkuthe
Copy link
Member

Needs a rebase then we can merge

@elliotfontaine
Copy link
Contributor Author

Needs a rebase then we can merge

Should be good now.

@the-mikedavis the-mikedavis merged commit 38faf74 into helix-editor:master Oct 30, 2024
6 checks passed
diucicd pushed a commit to diucicd/helix that referenced this pull request Nov 13, 2024
@elliotfontaine @the-mikedavis @rongyi
feat: Add support for cylc configuration files (helix-editor#11830)
9342a9c 
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elliotfontaine @the-mikedavis @pascalkuthe