helix-view: optionally bypass indent style auto detection #11920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code formatting styles are too challenging for the indent style auto detection heuristic. The indent style for C code in [GStreamer] should use 2 spaces, but auto detection leads to the followings being used: * [gst.c] -> 2 spaces. * [gstrtsp.c] -> 1 space. * [gstrtspsrc.c] -> 4 spaces. This commit adds the language configuration flag `auto-detect-indent` which defaults to `true`. When set to `false`, it bypasses auto detection, always using language defined indent style or `DEFAULT_INDENT` in last resort. [GStreamer]: https://gitlab.freedesktop.org/gstreamer/gstreamer [gst.c]: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gstreamer/gst/gst.c [gstrtsp.c]: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-good/gst/rtsp/gstrtsp.c [gstrtspsrc.c]: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-good/gst/rtsp/gstrtspsrc.c
|
I'm in favor of this but instead we can also look into improving the auto_detect_indent_style heuristic from something like NMAC427/guess-indent.nvim which is working for me almost perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code formatting styles are too challenging for the indent style auto detection heuristic.
The indent style for C code in GStreamer should use 2 spaces, but auto detection leads to the followings being used:
This commit adds the language configuration flag
auto-detect-indentwhich defaults totrue. When set tofalse, it bypasses auto detection, always using language defined indent style orDEFAULT_INDENTin last resort.