Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display long status messages as popups #12241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NikitaRevenco
Copy link
Contributor

@NikitaRevenco NikitaRevenco commented Dec 12, 2024

When a status line is too long to fit, it will instead be shown as a popup

Before

image

After

image

@David-Else
Copy link
Contributor

David-Else commented Dec 14, 2024

This seems essential, I am trying to read my 'failed to parse language config...` error right now and it is impossible, is there some workaround in the mean time?

Also, in your example the text is not red anymore, can it still use the theme colour for "error" if it is an error?

@TornaxO7
Copy link
Contributor

This seems essential, I am trying to read my 'failed to parse language config...` error right now and it is impossible, is there some workaround in the mean time?

I'd say: Take a look in the logs. You can get the path from the help page (hx --help)

@NikitaRevenco
Copy link
Contributor Author

This seems essential, I am trying to read my 'failed to parse language config...` error right now and it is impossible, is there some workaround in the mean time?

Also, in your example the text is not red anymore, can it still use the theme colour for "error" if it is an error?

Yep, so just fixed it

@David-Else
Copy link
Contributor

@NikitaRevenco Did you see this PR : #11239, it seems to have a lot in common with what you are doing here.

@NikitaRevenco
Copy link
Contributor Author

NikitaRevenco commented Dec 15, 2024

@NikitaRevenco Did you see this PR : #11239, it seems to have a lot in common with what you are doing here.

I saw it, the changes in that PR are specific to that command and cannot be re-used here from what I can tell

@TornaxO7
Copy link
Contributor

Also a relevant PR which tackles this: #11108

@NikitaRevenco
Copy link
Contributor Author

Also a relevant PR which tackles this: #11108

forgot to mention that this PR replaces that PR, since that PR doesn't actually fix the problem, text that is too long will still not be visible, as it only replaces newlines with spaces

@NikitaRevenco
Copy link
Contributor Author

Just rebased and fixed merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants