Truecolor friendly #1348
Closed
Truecolor friendly #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindSoilder
commented
Dec 23, 2021
| @@ -72,8 +90,8 @@ impl Loader { | |||
|
|
|||
| /// Lists all theme names available in default and user directory | |||
| pub fn names(&self) -> Vec<String> { | |||
There was a problem hiding this comment.
Actually I don't know why this exists, no using reference for this method.
There was a problem hiding this comment.
I think this was supposed to be used by the theme completion
archseer
reviewed
Jan 3, 2022
| @@ -2819,6 +2818,13 @@ pub mod cmd { | |||
| fun: theme, | |||
| completer: Some(completers::theme), | |||
| }, | |||
| TypableCommand { | |||
| name: "theme-base16", | |||
There was a problem hiding this comment.
I don't think this should be two different commands, just a single one that behaves differently depending on the config. For that to work, #1134 needs to land first though, since it adds cx to completions
the-mikedavis
added
the
S-waiting-on-author
|
Is there an interest in continuing this PR? I can close it if not. |
|
Sorry I don't have time for this, I'll close it.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1271
relative: #1311
Copies from my proposal:
providing a new command named
theme-base16, and it only prompt and allows user to activate non truecolor, base16 themes;To handle this efficiently, without looking into the theme itself to detect if it's true color theme. We can make a name convention for the name of theme:
non-truecolortheme namedbase16-xxxx.toml.truecolortheme.base16-xxx-256.toml(just like these base16 themes for iterm2: https://github.com/martinlindhe/base16-iterm2/tree/master/itermcolors). It will involve renaming base16_default_dark and base16_default_light.