Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate the start of file paths in the StatusLine #1351

Merged
merged 2 commits into from
Dec 25, 2021

Conversation

bbodi
Copy link
Contributor

@bbodi bbodi commented Dec 24, 2021

Fixes the same issue as in #945 but for the StatusLine.

Before:
image

We can see that the file name is truncated, while this is more important to the user than the path.

And in the second red rectangle, we can see that the letters "od" from the path is rendered outside of the statusline area.

After:
image

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Tested and looks good to me. I tested but still if I split too many times it will panic (well, current master also panic).

@pickfire
Copy link
Contributor

Lints needs to be fixed first before I merge this.

Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me 👍

@archseer archseer merged commit 60f3225 into helix-editor:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants