Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markup support #1525

Merged
merged 8 commits into from
Jan 23, 2022
Merged

Add markup support #1525

merged 8 commits into from
Jan 23, 2022

Conversation

NNBnh
Copy link
Contributor

@NNBnh NNBnh commented Jan 16, 2022

#TODO:

  • Base16:
    • base16_default
    • base16_default_dark
    • base16_default_light
    • base16_terminal
  • Everforest:
    • everforest_dark
    • everforest_light
  • Gruvbox:
    • gruvbox
    • gruvbox_light
  • Monokai:
    • monokai
    • monokai_pro
    • monokai_pro_machine
    • monokai_pro_octagon
    • monokai_pro_ristretto
    • monokai_pro_spectrum
  • Rose Pine:
    • rose_pine
    • rose_pine_dawn
  • Solarized:
    • solarized_dark
    • solarized_light
  • Other:
    • bogster
    • dark_plus
    • dracula
    • ingrid
    • nord
    • onedark
    • spacebones_light

@archseer
Copy link
Member

rose_pine themes already have them but the markup.link.text attribute is misnamed as markup.link.label

@pickfire
Copy link
Contributor

@NNBnh I think for those files without you can just add it in commented out with the defaults, the author or other people can go in and change it later easily.

@NNBnh
Copy link
Contributor Author

NNBnh commented Jan 17, 2022

@NNBnh I think for those files without you can just add it in commented out with the defaults, the author or other people can go in and change it later easily.

Okay I done it!

Preview for some small themes:

helix-markup.mp4

@archseer
Copy link
Member

\cc @WindSoilder could you add these missing scopes to your themes too?

@WindSoilder
Copy link
Contributor

WindSoilder commented Jan 21, 2022

\cc @WindSoilder could you add these missing scopes to your themes too?

Ok, have created a pr to handle monokai pro themes: #1553

@archseer
Copy link
Member

Merged! @NNBnh can you update this PR to remove the markup changes on monokai_ themes now?

@archseer
Copy link
Member

\cc @loewenheim @atog @kirawi @CptPotato etc so you're aware of these changes on your own themes. The newly added scopes are used for Markdown and will also be used for the documentation popup highlighting soon.

@archseer
Copy link
Member

Dracula was merged now too

@archseer archseer merged commit 83bde10 into helix-editor:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants