-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markup support #1525
Add markup support #1525
Conversation
rose_pine themes already have them but the markup.link.text attribute is misnamed as markup.link.label |
@NNBnh I think for those files without you can just add it in commented out with the defaults, the author or other people can go in and change it later easily. |
Okay I done it! Preview for some small themes: helix-markup.mp4 |
\cc @WindSoilder could you add these missing scopes to your themes too? |
Ok, have created a pr to handle monokai pro themes: #1553 |
Merged! @NNBnh can you update this PR to remove the markup changes on monokai_ themes now? |
\cc @loewenheim @atog @kirawi @CptPotato etc so you're aware of these changes on your own themes. The newly added scopes are used for Markdown and will also be used for the documentation popup highlighting soon. |
Dracula was merged now too |
#TODO
: