Upload source with gitmodules on release #1536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
There's #1560 open which replaces the submodule mechanism. |
3 tasks
archseer
reviewed
Jan 24, 2022
Comment on lines
+122
to
+124
| sudo apt-get update -qq -y | ||
| sudo apt-get install -qq -y python3-pip python3 | ||
| sudo pip3 install git-archive-all |
There was a problem hiding this comment.
I don't like the extra dependencies here. Since the submodules are already checked out it should be enough to package helix-syntax/languages/*. Let's hold off on this until we decide on #1560 though
There was a problem hiding this comment.
Yeah, for this case it should hopefully be simple enough to use tar with --exclude-vcs
|
We're going ahead with #1659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1451
Uploading a tar ball with submodules also makes live easier for linux distros which do not do git clones for package builds.