-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add csharp lsp support #1788
Add csharp lsp support #1788
Conversation
I don't think the This is my current language configuration (NixOS via home-manager) {
name = "c-sharp";
language-server = { command = "omnisharp"; args = [ "-l" "Error" "--languageserver" "-z" ]; };
} |
Thanks for taking a look. however as for -l Error, I don't believe we would want to limit the logging output to at least less than Warning. OmniSharp will warn on things like package version collisions, things being restored as .net framework, etc, which are all warnings that you wouldn't get as just Error. I also went through the source for http/stdio/cli and couldn't find what the -z is for, do you have a link for the docs for it? https://github.com/OmniSharp/omnisharp-roslyn/blob/8f045ddc1922a48ddb9dbe2009e902d1c61453d2/src/OmniSharp.Host/CommandLineApplication.cs and it seems you're right about hostPID, I had it auto fill in neovim, but it was working and I assume helix just closes the subprocess when it terminates, so I removed it. Let me know what you think. Thanks! |
Ok good to know, I agree with the logging output, let's keep it default. Regarding |
Could you commit the changes from |
Haha, -z was even in the link I posted, i just completely glossed over it somehow. And thanks, pushed the doc update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎉
* add csharp lsp support * remove hostPID * update docs
OmniSharp is the defacto LSP for C#, so this just adds it as the default. Tested on Windows/Linux