Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace line endings using set_line_ending command #1871

Merged
merged 3 commits into from
Apr 23, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion helix-term/src/commands/typed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ fn set_line_ending(
args: &[Cow<str>],
_event: PromptEvent,
) -> anyhow::Result<()> {
use helix_core::line_ending;
use LineEnding::*;

// If no argument, report current line ending setting.
Expand Down Expand Up @@ -321,8 +322,28 @@ fn set_line_ending(
arg if arg.starts_with("nel") => Nel,
_ => bail!("invalid line ending"),
};
let (view, doc) = current!(cx.editor);
doc.line_ending = line_ending;

let mut pos = 0;
let transaction = Transaction::change(
doc.text(),
doc.text().lines().filter_map(|line| {
let current_pos = pos;
pos += line.len_chars();
match line_ending::get_line_ending(&line) {
Some(ending) if ending != line_ending => {
let start = current_pos + line_ending::rope_end_without_line_ending(&line);
kirawi marked this conversation as resolved.
Show resolved Hide resolved
let end = pos;
Some((start, end, Some(line_ending.as_str().into())))
}
_ => None,
}
}),
);

doc.apply(&transaction, view.id);

doc_mut!(cx.editor).line_ending = line_ending;
Ok(())
}

Expand Down